Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci.yml: PyPI uses oidc for auth #97

Merged
merged 1 commit into from
Nov 26, 2023
Merged

ci.yml: PyPI uses oidc for auth #97

merged 1 commit into from
Nov 26, 2023

Conversation

james-rms
Copy link
Contributor

@james-rms james-rms commented Nov 24, 2023

Public-Facing Changes

None.

Description

I've set up pypi to authorize GitHub Actions to push packages from this repo, following this guide: https://docs.github.com/en/actions/deployment/security-hardening-your-deployments/configuring-openid-connect-in-pypi

After this change, the PYPI_API_TOKEN (and TESTPYPI) github secrets are no longer required and can be removed.

Copy link

@defunctzombie defunctzombie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you elaborate on what this change is? Like can I remove the _API_TOKEN secrets from the repo? How does this repo have writes to publish without the token?

@james-rms james-rms merged commit 3085c74 into main Nov 26, 2023
2 checks passed
@james-rms james-rms deleted the jrms/oidc-pypi branch November 26, 2023 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants