Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: other icon for marked Focus pool point #16922

Open
robinsving opened this issue Oct 17, 2024 · 6 comments
Open

Feature request: other icon for marked Focus pool point #16922

robinsving opened this issue Oct 17, 2024 · 6 comments

Comments

@robinsving
Copy link

We have the marked Focus pool point

We can see it:

<i class="{{#if (gt @root.data.resources.focus.value this)}}fa-solid fa-dot-circle{{else}}fa-regular fa-circle{{/if}}"></i>

fa-solid fa-dot-circle

I'd like this to be changed to e.g. <i class="fa-regular fa-circle-xmark"></i> as that makes it easier to understand what it means.

@robinsving
Copy link
Author

image
vs
image

@AFigureOfBlue
Copy link
Contributor

AFigureOfBlue commented Oct 20, 2024

I feel like the current one (the top of the two images you've posted) is the more intuitive one to me, and also the easier of them to read at a glance ('filled in' vs 'not filled in' reads more quickly to my eye than 'with an x' and 'without an x'). Could you share a bit more about in what ways you find the alternative you've presented to be easier to understand?

@CarlosFdez
Copy link
Collaborator

Veto from my end to the proposed solution though I'm amenable to alternative icons. Ideally a nested but filled in thick circle would be the most ideal to me. Right now its just a thicker donut, but I'd like the donut hole to be filled in personally.

@robinsving
Copy link
Author

The solid one looks like it is full and the empty one is, well, empty, hence my confusion (i.e. "the pool is empty if the icons are empty").
I am also fine with any other option, but the current one has given me in-play issues more than once.

@CarlosFdez
Copy link
Collaborator

CarlosFdez commented Oct 20, 2024

You're the only one I've heard have that issue. I would expect more likely that that left click to remove and right click to add created more issues than that.

@CrackJackFlood
Copy link
Contributor

You're the only one I've heard have that issue. I would expect more likely that that left click to remove and right click to add created more issues than that.

Me and my players often get tripped up by it, never complained because its kind of insignificant, suggestions would be to copy how Hero Points look but instead have a F instead of a H or have it be a number (though I imagine most people prefer the visuals of pips I personally would prefer numbers for resources)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants