Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: refactor debugger dump code #9170

Merged
merged 1 commit into from
Oct 23, 2024
Merged

chore: refactor debugger dump code #9170

merged 1 commit into from
Oct 23, 2024
+61 −64

Conversation

grandizzy
Copy link
Collaborator

Motivation

  • follow up from Add debug file dump #7375 PR, simplify and format
  • refactor code to have impls right after struct declaration
  • move file_dumper in root
  • remove context mod

Solution

@grandizzy grandizzy marked this pull request as ready for review October 23, 2024 11:41
zerosnacks
zerosnacks approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@zerosnacks zerosnacks left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@zerosnacks zerosnacks merged commit 2cdf718 into foundry-rs:master Oct 23, 2024
21 checks passed
leovct pushed a commit to leovct/foundry that referenced this pull request Oct 23, 2024
@grandizzy @leovct
chore: refactor debugger dump code (foundry-rs#9170)
0952279 
chore: refactor debugger code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zerosnacks zerosnacks zerosnacks approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@yash-atreya yash-atreya Awaiting requested review from yash-atreya yash-atreya is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Foundry
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grandizzy @zerosnacks