A set of device list cleanups #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to fully move an argument parsing logic from the client into the command. Before the change, an argument parsing logic was split between the two. Signed-off-by: Volodymyr Khoroz <[email protected]>
A new API has a newer name argument for few months already. Use it instead of the obsolete name_ilike. Signed-off-by: Volodymyr Khoroz <[email protected]>
Currently, we onlhy special-cased the URL escaping of a ? for device name pattern. But, other characters are not escaped, and uuid pattern is not escaped at all. Most of the time this just works, but may produce unexpected results. For example `fioctl devices list 'a*&'` will ignore the trailing ampersand, and behave just like `fioctl device list 'a*'`, matching unexpected devices. Using the `net/url` to URL escape the query makes filtering more predictable for such edge cases. Signed-off-by: Volodymyr Khoroz <[email protected]>
This shortens the URL, making it easier to debug. Signed-off-by: Volodymyr Khoroz <[email protected]>
doanac
reviewed
Apr 19, 2024
mike-sul
reviewed
Apr 22, 2024
mike-sul
reviewed
Apr 22, 2024
mike-sul
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.