fix(device): always take apps input as source of truth #378
Conversation
| @@ -226,16 +226,13 @@ func SetUpdatesConfig(opts *SetUpdatesConfigOptions, reportedTag string, reporte | |||
| if len(configuredTag) == 0 && len(reportedTag) > 0 { | |||
| configuredTag = reportedTag | |||
| } | |||
| if len(configuredApps) == 0 && reportedApps != nil { | |||
| configuredApps = strings.Join(reportedApps, ",") | |||
| } | |||
There was a problem hiding this comment.
I believe that the reportedTag is subject to the same problem as reportedApps.
So, it'd be wise to update that logic accordingly as well.
There was a problem hiding this comment.
note - this is rolling back a "fix" - a8a21c7
There was a problem hiding this comment.
or is it. i'm confused. can you add a little more to the commit message?
There was a problem hiding this comment.
@doanac IIUC that fix is nice, but it introduced another bug we were discussing today.
So, Eric has now moved it to a better place (see lines below).
There was a problem hiding this comment.
note - this is rolling back a "fix" - a8a21c7
I think that issue can be fixed by making fioconfig send the config to DG. It becomes possible with this change foundriesio/fioconfig#45.
Instead of overriding the input given with what our api is giving back, it is much better to just take what the user is giving us as what needs to be set. Signed-off-by: Eric Bode <[email protected]>
StealthyCoder
force-pushed
the
fix/config_apps
branch
from
f9f6852
to
1d44591
Compare
Instead of overriding the input given with what our api is giving back, it is much better to just take what the user is giving us as what needs to be set.