(chore): add unconvert linter check and fix issues #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camilamacedo86
force-pushed
the
add-unconvert-linter
branch
from
e37ff78
to
7777603
Compare
camilamacedo86
changed the title
camilamacedo86
force-pushed
the
add-unconvert-linter
branch
from
7777603
to
c47ee2b
Compare
camilamacedo86
changed the title
vkhoroz
reviewed
Sep 29, 2023
There was a problem hiding this comment.
I like this one, but lets pause on this.
I mean, keep open but don't merge yet.
A current way how we run linter does not cover the Golang based PKI implementation (because of the build tag).
I've enabled verification of that thing and fixed some linter warnings in #278.
Once that goes in, we can enable this and fix all new warnings at once (there shouldn't be many for this specific linter check).
camilamacedo86
force-pushed
the
add-unconvert-linter
branch
from
c47ee2b
to
b18829d
Compare
|
HI @vkhoroz, Thank you for your input . Regards: #282 (review) Just to clarify, the current check is focused on unnecessary conversions. So, unless there are such conversions in the changes you mentioned, this check shouldn't raise any issues. But if you want to wait for #278 that is all fine. |
Signed-off-by: Camila Macedo <[email protected]>
camilamacedo86
force-pushed
the
add-unconvert-linter
branch
from
b18829d
to
a3cd4ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.