Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Windows path issues #1282

Draft
wants to merge 2 commits into
base: use-pathext
Choose a base branch
from
Draft

Conversation

zlav
Copy link
Member

@zlav zlav commented Sep 21, 2023

Overview

This PR is to create a working build of a Windows fix Jess worked on that now has expired binaries. This is only for testing purposes

Acceptance criteria

If this PR is successful, what impact does it have on the user experience?

Example: When users do X, Y should now happen.

Testing plan

How did you validate that this PR works? What literal steps did you take when manually checking that your code works?

Example:

  1. Set up test case X.
  2. Run command Y. Make sure Z happens.

This section should list concrete steps that a reviewer can sanity check and repeat on their own machine (and provide any needed test cases).

Risks

Highlight any areas that you're unsure of, want feedback on, or want reviewers to pay particular attention to.

Example: I'm not sure I did X correctly, can reviewers please double-check that for me?

Metrics

Is this change something that can or should be tracked? If so, can we do it today? And how? If its easy, do it

References

Add links to any referenced GitHub issues, Zendesk tickets, Jira tickets, Slack threads, etc.

Example:

Checklist

  • I added tests for this PR's change (or explained in the PR description why tests don't make sense).
  • If this PR introduced a user-visible change, I added documentation into docs/.
  • If this change is externally visible, I updated Changelog.md. If this PR did not mark a release, I added my changes into an # Unreleased section at the top.
  • If I made changes to .fossa.yml or fossa-deps.{json.yml}, I updated docs/references/files/*.schema.json. You may also need to update these if you have added/removed new dependency type (e.g. pip) or analysis target type (e.g. poetry).
  • If I made changes to a subcommand's options, I updated docs/references/subcommands/<subcommand>.md.

This PR is to create a working build of a Windows fix Jess worked on that now has expired binaries. This is only for testing purposes
@zlav zlav requested a review from a team as a code owner September 21, 2023 20:46
@zlav zlav requested review from spatten and removed request for a team September 21, 2023 20:46
@zlav zlav marked this pull request as draft September 21, 2023 20:46
@zlav zlav changed the title [DO NOT MERGE] w [DO NOT MERGE] Windows path issues Sep 21, 2023
@zlav zlav removed the request for review from spatten September 21, 2023 20:46
@csasarak
Copy link
Contributor

csasarak commented Sep 8, 2024

@zlav Can this be closed for now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants