Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timing inaccuraries #2

Open
lennart opened this issue Oct 12, 2015 · 5 comments
Open

Timing inaccuraries #2

lennart opened this issue Oct 12, 2015 · 5 comments

Comments

@lennart
Copy link
Collaborator

lennart commented Oct 12, 2015

Currently timing seems to be not quite right.

Scheduling of rendering shaders could be done just as dirt does, or completely disregard timing information and change weltfrieden to not expect timestamps.

@lennart
Copy link
Collaborator Author

lennart commented Oct 12, 2015

@yaxu since you mentioned this, I did implement queue handling just as in dirt in eec783e this should schedule all messages appropriately, though I haven't tested this throroughly.

Did you already test this version (I just pushed this yesterday evening)? If so, I am wondering why it still fails to be on time.

@yaxu
Copy link

yaxu commented Oct 12, 2015

Yes I am up to date with the latest code and did make clean / make.

Reduce the cps and you'll see that in effect everything is quantised to a resolution of one eighth of a cycle.. So I guess this is a bug somewhere with the scheduling.

@lennart
Copy link
Collaborator Author

lennart commented Oct 12, 2015

Thanks for the investigation, I'll have to take a good look at the scheduling code, especially regarding the order of shader layers rendered.

On Oct 12, 2015, at 12:05 PM, Alex McLean [email protected] wrote:

Yes I am up to date with the latest code and did make clean / make.

Reduce the cps and you'll see that in effect everything is quantised to a resolution of one eighth of a cycle.. So I guess this is a bug somewhere with the scheduling.


Reply to this email directly or view it on GitHub.

@lennart
Copy link
Collaborator Author

lennart commented Oct 13, 2015

@yaxu I found the bug and (hopefully) have fixed it. I have been assigning the globaltime to ->when whenever a message has been received. now it's using the supplied values as scheduled by tidal.

this looks more in sync now.

however layering seems to be still not quite right (please test vowel params a lot, since this might help seeing multiple layers above another, as not all have alpha values below 1)

@lennart
Copy link
Collaborator Author

lennart commented Dec 11, 2015

I did not notice any more timing errors, but will leave this open until more people have used it…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants