Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation of --killSignal #1146

Open
getify opened this issue Sep 25, 2024 · 0 comments
Open

Improve documentation of --killSignal #1146

getify opened this issue Sep 25, 2024 · 0 comments

Comments

@getify
Copy link

getify commented Sep 25, 2024

I discovered, almost by accident, something rather unintuitive: the --killSignal=... CLI parameter doesn't have any effect with the forever stop command, as one might expect.

Instead, you have to pass this CLI parameter to the previous forever start command. Then, a subsequent forever stop ... command can be issued (without --killSignal), and it will use the kill-signal as specified in the forever start command.

While that design is unusual and counterintuitive, I suspect maybe there's some deeper reason for it. So all I'm suggesting here is that the documentation -- specifically the CLI --help output -- include this important detail. That might save other folks the 30 minutes I lost.

Happy to PR if this is acceptable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant