Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update immer.js #2988

Open
fonsp opened this issue Aug 11, 2024 · 1 comment · Fixed by #2993
Open

Update immer.js #2988

fonsp opened this issue Aug 11, 2024 · 1 comment · Fixed by #2993
Labels
dependencies Pull requests that update a dependency file frontend Concerning the HTML editor performance

Comments

@fonsp
Copy link
Owner

fonsp commented Aug 11, 2024

v10 is out and we use v8. Should be 33% faster
@fonsp fonsp added frontend Concerning the HTML editor dependencies Pull requests that update a dependency file labels Aug 11, 2024
@fonsp fonsp mentioned this issue Aug 12, 2024
Merged
@fonsp fonsp reopened this Aug 15, 2024
@fonsp
Copy link
Owner Author

fonsp commented Aug 15, 2024

I reverted the upgrade in 7354eb8

Because this broke:

Pluto.jl/frontend/components/Editor.js

Line 712 in 7354eb8

const failing_path = String(exception).match(".*'(.*)'.*")?.[1].replace(/\//gi, ".") ?? exception

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file frontend Concerning the HTML editor performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade immer to 10.1.1 fonsp/Pluto.jl
1 participant
@fonsp