Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

what's the right way for theming this? #2

Open
krtschmr opened this issue Aug 18, 2019 · 1 comment
Open

what's the right way for theming this? #2

krtschmr opened this issue Aug 18, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@krtschmr
Copy link

krtschmr commented Aug 18, 2019

i'm coming from bootstrap, i wonder what would be the correct way to do in in semanticui?
i expected to just load the variables, then load custom variables/overrides and load the rest of the css to compile it. however:

there are like no variables
https://github.com/fomantic/Fomantic-UI-SASS/blob/master/app/assets/stylesheets/semantic-ui/globals/_variables.scss

and colors etc are hardcoded
https://github.com/fomantic/Fomantic-UI-SASS/blob/master/app/assets/stylesheets/semantic-ui/elements/_loader.scss

the LESS file has it with variables: https://github.com/fomantic/Fomantic-UI/blob/master/src/definitions/elements/loader.less

if i read it correctly, this gem is a bit useless since it won't allow us customization as we should be able to do it?

@shanecav84
Copy link
Collaborator

You are correct that this gem doesn't support theming. I will take a look into adding it in.

@shanecav84 shanecav84 added the enhancement New feature or request label Sep 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants