OKAPI-1189: Add "extensions" field to module descriptor #1357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| @@ -80,6 +80,10 @@ | |||
| "launchDescriptor": { | |||
| "description": "Default deployment for this module", | |||
| "$ref": "LaunchDescriptor.json" | |||
| }, | |||
| "extensions" : { | |||
| "description": "Sets extensions for ModuleDescriptor that can store custom or meta information.", | |||
There was a problem hiding this comment.
Deleting redundant information allows to reduce the description to "Custom or meta information."
| @@ -80,6 +80,10 @@ | |||
| "launchDescriptor": { | |||
| "description": "Default deployment for this module", | |||
| "$ref": "LaunchDescriptor.json" | |||
| }, | |||
| "extensions" : { | |||
| "description": "Sets extensions for ModuleDescriptor that can store custom or meta information.", | |||
There was a problem hiding this comment.
https://folio-org.atlassian.net/browse/OKAPI-732 has already added such a field to ModuleDescriptor, it is called “metadata”.
I don’t see a need to duplicate it. What is the difference between the “metadata” field and the “extensions” field?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Eureka has introduced new fields to the module descriptor in order to support the declarative specification of system/tenant users. These changes are incompatible with Okapi. After reviewing solutions, the decision was made to add a new field to the module descriptor “extensions”, and update the necessary code in both Eureka (mgr-*) and Okapi.
See wiki for additional details.
OKAPI-1189
Scope