Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the code stop if IO fails? #903

Open
ykempf opened this issue Feb 5, 2024 · 1 comment
Open

Make the code stop if IO fails? #903

ykempf opened this issue Feb 5, 2024 · 1 comment

Comments

@ykempf
Copy link
Contributor

ykempf commented Feb 5, 2024

Do we want the code to stop if IO fails eg due to disk quota being full? Or do we want to just chug along in the hope that someone notices and cleans up? #1Mburn

@lkotipal
Copy link
Contributor

lkotipal commented Feb 5, 2024

I'd say bulk write fails qualify for fatal errors since we'll end up with a long stretch of missing files if someone isn't there just in time to catch the error. However, restart writes tend to fail more often (due to the size) and might be recoverable; if the bad restart file is cleaned up and the user notified, it's reasonable to catch that in the output before the quota gets so full nothing can be written.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants