Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMR refinement parameters are actually half-widths/heights/thicknesses #792

Open
ykempf opened this issue Jul 4, 2023 · 4 comments
Open

Comments

@ykempf
Copy link
Contributor

ykempf commented Jul 4, 2023

[Magnetosphere]
refine_L1tailthick = 6.371e7 # 10 RE
refine_L2tailthick = 2.5e7 # 3.92 RE
refine_L3tailheight = 1.0e7
refine_L3tailwidth = 8.0e7

These parameters are actually half-widths, heights, thicknesses, which got me confused in a test. Should they be renamed? And while at it, height is the same concept as thick in these.

@lkotipal
Copy link
Contributor

lkotipal commented Jul 7, 2023

Thick is y and z, height and width are single dimensional. They should really be renamed though, with maybe explicit dimensions in height and width as well, eg.:
refine_LN_tail_yz_max
refine_L3_tail_y_max
Or something to that effect.

@markusbattarbee
Copy link
Contributor

refine_L1tailthick and refine_L2tailthick are not evaluated in the y-direction, only in z. The y-directional width of the tail sheet is dictated by the L1 or L2 ionospheric refinement region radius.

Thus the L3 tail sheet uses height and width, which dictate the box extents in the y-z-plane. So I kinda like having a different name for that (thick vs height).

@ykempf
Copy link
Contributor Author

ykempf commented Aug 14, 2023

Well, OK then, close this and make a mental note that these are halves?

@markusbattarbee
Copy link
Contributor

or learn to read the comments in Magnetosphere.cpp :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants