Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(New) AMR criteria: on by default with sensible values or off to avoid accidental refinement? #1028

Open
ykempf opened this issue Sep 18, 2024 · 0 comments

Comments

@ykempf
Copy link
Contributor

ykempf commented Sep 18, 2024

In testing I was "surprised" to get default-valued active vorticity refinement when it wasn't called for in the cfg. We had decided that at least alpha1 and 2 should be on by default with sensible values when refinement is active. As we're moving towards more varied and somewhat specific criteria (e.g. targeting the foreshock with anisotropy) I'd advocate for us to change tack and not make all of them active by default. Maybe alpha1 and 2 could be on by default, but vorticity and anisotropy maybe should be off by default, albeit with sensible default values for their parameters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant