From e7a764805a71d5c018c0b43b67c17f0ccb723d21 Mon Sep 17 00:00:00 2001
From: Alho Markku J <markku.alho@helsinki.fi>
Date: Fri, 23 Aug 2024 08:29:18 +0300
Subject: [PATCH 01/19] Added example test workflow

---
 .github/workflows/test_python.yml | 40 +++++++++++++++++++++++++++++++
 1 file changed, 40 insertions(+)
 create mode 100644 .github/workflows/test_python.yml

diff --git a/.github/workflows/test_python.yml b/.github/workflows/test_python.yml
new file mode 100644
index 00000000..206807df
--- /dev/null
+++ b/.github/workflows/test_python.yml
@@ -0,0 +1,40 @@
+# This workflow will install Python dependencies, run tests and lint with a variety of Python versions
+# For more information see: https://docs.github.com/en/actions/automating-builds-and-tests/building-and-testing-python
+
+name: Python package
+
+on:
+  push:
+    branches: [ $default-branch ]
+  pull_request:
+    branches: [ $default-branch ]
+
+jobs:
+  build:
+
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        python-version: ["3.9", "3.10", "3.11"]
+
+    steps:
+    - uses: actions/checkout@v4
+    - name: Set up Python ${{ matrix.python-version }}
+      uses: actions/setup-python@v3
+      with:
+        python-version: ${{ matrix.python-version }}
+    - name: Install dependencies
+      run: |
+        python -m pip install --upgrade pip
+        python -m pip install flake8 pytest
+        if [ -f requirements.txt ]; then pip install -r requirements.txt; fi
+    - name: Lint with flake8
+      run: |
+        # stop the build if there are Python syntax errors or undefined names
+        flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics
+        # exit-zero treats all errors as warnings. The GitHub editor is 127 chars wide
+        flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --statistics
+    - name: Test with pytest
+      run: |
+        pytest
\ No newline at end of file

From ab5335a35f97e03ceb8e4cb2865f10521f32116e Mon Sep 17 00:00:00 2001
From: Alho Markku J <markku.alho@helsinki.fi>
Date: Fri, 23 Aug 2024 08:34:31 +0300
Subject: [PATCH 02/19] Some specialization

---
 .github/workflows/test_python.yml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/.github/workflows/test_python.yml b/.github/workflows/test_python.yml
index 206807df..d0ece38d 100644
--- a/.github/workflows/test_python.yml
+++ b/.github/workflows/test_python.yml
@@ -29,12 +29,15 @@ jobs:
         python -m pip install --upgrade pip
         python -m pip install flake8 pytest
         if [ -f requirements.txt ]; then pip install -r requirements.txt; fi
+        python -m pip install numpy scipy matplotlib  # add versions to matrix
     - name: Lint with flake8
       run: |
         # stop the build if there are Python syntax errors or undefined names
         flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics
         # exit-zero treats all errors as warnings. The GitHub editor is 127 chars wide
         flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --statistics
+    - name: Trial imports
+      run: python pytools.py
     - name: Test with pytest
       run: |
         pytest
\ No newline at end of file

From 4370b29970f636e35d8db3dac9dede2e167d5c8f Mon Sep 17 00:00:00 2001
From: Alho Markku J <markku.alho@helsinki.fi>
Date: Fri, 23 Aug 2024 08:38:21 +0300
Subject: [PATCH 03/19] Enable workflow on the branch?

---
 .github/workflows/test_python.yml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/test_python.yml b/.github/workflows/test_python.yml
index d0ece38d..41efdd8d 100644
--- a/.github/workflows/test_python.yml
+++ b/.github/workflows/test_python.yml
@@ -5,9 +5,9 @@ name: Python package
 
 on:
   push:
-    branches: [ $default-branch ]
+    branches: [ $default-branch CI_introduction]
   pull_request:
-    branches: [ $default-branch ]
+    branches: [ $default-branch CI_introduction]
 
 jobs:
   build:

From 1f69259c61c97441a355e9e35aef34c3754f4b63 Mon Sep 17 00:00:00 2001
From: Alho Markku J <markku.alho@helsinki.fi>
Date: Fri, 23 Aug 2024 08:41:27 +0300
Subject: [PATCH 04/19] workflow_dispatch

---
 .github/workflows/test_python.yml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/.github/workflows/test_python.yml b/.github/workflows/test_python.yml
index 41efdd8d..e4a5acd3 100644
--- a/.github/workflows/test_python.yml
+++ b/.github/workflows/test_python.yml
@@ -8,6 +8,7 @@ on:
     branches: [ $default-branch CI_introduction]
   pull_request:
     branches: [ $default-branch CI_introduction]
+  workflow_dispatch:
 
 jobs:
   build:

From 25b208a56e484f086a36d38ae97382967450a8c0 Mon Sep 17 00:00:00 2001
From: Markku Alho <markku.alho@helsinki.fi>
Date: Fri, 23 Aug 2024 08:43:27 +0300
Subject: [PATCH 05/19] Update test_python.yml

endline
---
 .github/workflows/test_python.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/test_python.yml b/.github/workflows/test_python.yml
index e4a5acd3..db099775 100644
--- a/.github/workflows/test_python.yml
+++ b/.github/workflows/test_python.yml
@@ -41,4 +41,4 @@ jobs:
       run: python pytools.py
     - name: Test with pytest
       run: |
-        pytest
\ No newline at end of file
+        pytest

From 6a42fed67900c39afd3e0d06f51554b667a2735c Mon Sep 17 00:00:00 2001
From: Alho Markku J <markku.alho@helsinki.fi>
Date: Fri, 23 Aug 2024 08:47:16 +0300
Subject: [PATCH 06/19] Split linting and testing

---
 .github/workflows/{test_python.yml => python_lint.yml} | 0
 1 file changed, 0 insertions(+), 0 deletions(-)
 rename .github/workflows/{test_python.yml => python_lint.yml} (100%)

diff --git a/.github/workflows/test_python.yml b/.github/workflows/python_lint.yml
similarity index 100%
rename from .github/workflows/test_python.yml
rename to .github/workflows/python_lint.yml

From 8d659513d4e29158063781911f8b1d098bf9fe8b Mon Sep 17 00:00:00 2001
From: Alho Markku J <markku.alho@helsinki.fi>
Date: Fri, 23 Aug 2024 08:52:04 +0300
Subject: [PATCH 07/19] renames

---
 .github/workflows/python_lint.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/python_lint.yml b/.github/workflows/python_lint.yml
index db099775..97ddb78d 100644
--- a/.github/workflows/python_lint.yml
+++ b/.github/workflows/python_lint.yml
@@ -1,7 +1,7 @@
 # This workflow will install Python dependencies, run tests and lint with a variety of Python versions
 # For more information see: https://docs.github.com/en/actions/automating-builds-and-tests/building-and-testing-python
 
-name: Python package
+name: Python linting with flake8
 
 on:
   push:

From 9552c08e9c8c305f7e7f56af10db109e3cdc29bf Mon Sep 17 00:00:00 2001
From: Alho Markku J <markku.alho@helsinki.fi>
Date: Fri, 23 Aug 2024 08:52:53 +0300
Subject: [PATCH 08/19] Missed add

---
 .github/workflows/python_import.yml | 38 +++++++++++++++++++++++++++++
 1 file changed, 38 insertions(+)
 create mode 100644 .github/workflows/python_import.yml

diff --git a/.github/workflows/python_import.yml b/.github/workflows/python_import.yml
new file mode 100644
index 00000000..185ce50d
--- /dev/null
+++ b/.github/workflows/python_import.yml
@@ -0,0 +1,38 @@
+# This workflow will install Python dependencies, run tests and lint with a variety of Python versions
+# For more information see: https://docs.github.com/en/actions/automating-builds-and-tests/building-and-testing-python
+
+name: Python import test
+
+on:
+  push:
+    branches: [ $default-branch CI_introduction]
+  pull_request:
+    branches: [ $default-branch CI_introduction]
+  workflow_dispatch:
+
+jobs:
+  build:
+
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        python-version: ["3.9", "3.10", "3.11"]
+
+    steps:
+    - uses: actions/checkout@v4
+    - name: Set up Python ${{ matrix.python-version }}
+      uses: actions/setup-python@v3
+      with:
+        python-version: ${{ matrix.python-version }}
+    - name: Install dependencies
+      run: |
+        python -m pip install --upgrade pip
+        python -m pip install pytest
+        if [ -f requirements.txt ]; then pip install -r requirements.txt; fi
+        python -m pip install numpy scipy matplotlib  # add versions to matrix
+    - name: Trial imports
+      run: python pytools.py
+    - name: Test with pytest
+      run: |
+        pytest

From 0b1c8a000ae07a1f95df8229fe01005fd93a9662 Mon Sep 17 00:00:00 2001
From: Alho Markku J <markku.alho@helsinki.fi>
Date: Fri, 23 Aug 2024 08:57:05 +0300
Subject: [PATCH 09/19] No pytests yet, linter workflow to only lint

---
 .github/workflows/python_import.yml | 6 +++---
 .github/workflows/python_lint.yml   | 6 +-----
 2 files changed, 4 insertions(+), 8 deletions(-)

diff --git a/.github/workflows/python_import.yml b/.github/workflows/python_import.yml
index 185ce50d..a0e3d231 100644
--- a/.github/workflows/python_import.yml
+++ b/.github/workflows/python_import.yml
@@ -33,6 +33,6 @@ jobs:
         python -m pip install numpy scipy matplotlib  # add versions to matrix
     - name: Trial imports
       run: python pytools.py
-    - name: Test with pytest
-      run: |
-        pytest
+    # - name: Test with pytest
+    #   run: |
+    #     pytest
diff --git a/.github/workflows/python_lint.yml b/.github/workflows/python_lint.yml
index 97ddb78d..3d540b5f 100644
--- a/.github/workflows/python_lint.yml
+++ b/.github/workflows/python_lint.yml
@@ -37,8 +37,4 @@ jobs:
         flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics
         # exit-zero treats all errors as warnings. The GitHub editor is 127 chars wide
         flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --statistics
-    - name: Trial imports
-      run: python pytools.py
-    - name: Test with pytest
-      run: |
-        pytest
+

From 0f27ea7fa68ca0d8190aa2780c3b9ca2f60c3d62 Mon Sep 17 00:00:00 2001
From: Alho Markku J <markku.alho@helsinki.fi>
Date: Fri, 23 Aug 2024 09:57:14 +0300
Subject: [PATCH 10/19] Scikit-image and python version spread

---
 .github/workflows/python_import.yml | 8 ++++----
 .github/workflows/python_lint.yml   | 8 ++++----
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/.github/workflows/python_import.yml b/.github/workflows/python_import.yml
index a0e3d231..3f1faa29 100644
--- a/.github/workflows/python_import.yml
+++ b/.github/workflows/python_import.yml
@@ -5,9 +5,9 @@ name: Python import test
 
 on:
   push:
-    branches: [ $default-branch CI_introduction]
+    branches: [ master ]
   pull_request:
-    branches: [ $default-branch CI_introduction]
+    branches: [ master ]
   workflow_dispatch:
 
 jobs:
@@ -17,7 +17,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        python-version: ["3.9", "3.10", "3.11"]
+        python-version: ["3.6", "3.9", "3.10", "3.11"]
 
     steps:
     - uses: actions/checkout@v4
@@ -30,7 +30,7 @@ jobs:
         python -m pip install --upgrade pip
         python -m pip install pytest
         if [ -f requirements.txt ]; then pip install -r requirements.txt; fi
-        python -m pip install numpy scipy matplotlib  # add versions to matrix
+        python -m pip install numpy scipy matplotlib scikit-image # add versions to matrix
     - name: Trial imports
       run: python pytools.py
     # - name: Test with pytest
diff --git a/.github/workflows/python_lint.yml b/.github/workflows/python_lint.yml
index 3d540b5f..f0f01b10 100644
--- a/.github/workflows/python_lint.yml
+++ b/.github/workflows/python_lint.yml
@@ -5,9 +5,9 @@ name: Python linting with flake8
 
 on:
   push:
-    branches: [ $default-branch CI_introduction]
+    branches: [ master ]
   pull_request:
-    branches: [ $default-branch CI_introduction]
+    branches: [ master ]
   workflow_dispatch:
 
 jobs:
@@ -17,7 +17,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        python-version: ["3.9", "3.10", "3.11"]
+        python-version: ["3.6", "3.9", "3.10", "3.11"]
 
     steps:
     - uses: actions/checkout@v4
@@ -30,7 +30,7 @@ jobs:
         python -m pip install --upgrade pip
         python -m pip install flake8 pytest
         if [ -f requirements.txt ]; then pip install -r requirements.txt; fi
-        python -m pip install numpy scipy matplotlib  # add versions to matrix
+        python -m pip install numpy scipy matplotlib scikit-image  # add versions to matrix
     - name: Lint with flake8
       run: |
         # stop the build if there are Python syntax errors or undefined names

From 200511127609e329fb2c796e81045b961c6d9df2 Mon Sep 17 00:00:00 2001
From: Alho Markku J <markku.alho@helsinki.fi>
Date: Fri, 23 Aug 2024 09:58:39 +0300
Subject: [PATCH 11/19] Existing version...

---
 .github/workflows/python_import.yml | 2 +-
 .github/workflows/python_lint.yml   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/python_import.yml b/.github/workflows/python_import.yml
index 3f1faa29..28d60056 100644
--- a/.github/workflows/python_import.yml
+++ b/.github/workflows/python_import.yml
@@ -17,7 +17,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        python-version: ["3.6", "3.9", "3.10", "3.11"]
+        python-version: ["3.7.1", "3.9", "3.10", "3.11"]
 
     steps:
     - uses: actions/checkout@v4
diff --git a/.github/workflows/python_lint.yml b/.github/workflows/python_lint.yml
index f0f01b10..648e28e2 100644
--- a/.github/workflows/python_lint.yml
+++ b/.github/workflows/python_lint.yml
@@ -17,7 +17,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        python-version: ["3.6", "3.9", "3.10", "3.11"]
+        python-version: ["3.7.1", "3.9", "3.10", "3.11"]
 
     steps:
     - uses: actions/checkout@v4

From baa7e459ddfe46d7ecfe5c2fef93939abb3f73f3 Mon Sep 17 00:00:00 2001
From: Alho Markku J <markku.alho@helsinki.fi>
Date: Sat, 24 Aug 2024 17:22:10 +0300
Subject: [PATCH 12/19] fiddling

---
 .github/workflows/python_import.yml | 4 ++--
 .github/workflows/python_lint.yml   | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/.github/workflows/python_import.yml b/.github/workflows/python_import.yml
index 28d60056..9c3e945f 100644
--- a/.github/workflows/python_import.yml
+++ b/.github/workflows/python_import.yml
@@ -11,13 +11,13 @@ on:
   workflow_dispatch:
 
 jobs:
-  build:
+  import:
 
     runs-on: ubuntu-latest
     strategy:
       fail-fast: false
       matrix:
-        python-version: ["3.7.1", "3.9", "3.10", "3.11"]
+        python-version: ["3.7", "3.9", "3.10", "3.11"]
 
     steps:
     - uses: actions/checkout@v4
diff --git a/.github/workflows/python_lint.yml b/.github/workflows/python_lint.yml
index 648e28e2..9d9b19a5 100644
--- a/.github/workflows/python_lint.yml
+++ b/.github/workflows/python_lint.yml
@@ -17,7 +17,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        python-version: ["3.7.1", "3.9", "3.10", "3.11"]
+        python-version: ["3.7", "3.9", "3.10", "3.11"]
 
     steps:
     - uses: actions/checkout@v4

From 7ba9a63bd1d34d4c446516fc00957772b2bc85d0 Mon Sep 17 00:00:00 2001
From: Alho Markku J <markku.alho@helsinki.fi>
Date: Tue, 27 Aug 2024 14:57:20 +0300
Subject: [PATCH 13/19] Linter as a jobstep, continue-on-error?

---
 .github/workflows/python_import.yml | 35 +++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)

diff --git a/.github/workflows/python_import.yml b/.github/workflows/python_import.yml
index 9c3e945f..135f8dee 100644
--- a/.github/workflows/python_import.yml
+++ b/.github/workflows/python_import.yml
@@ -36,3 +36,38 @@ jobs:
     # - name: Test with pytest
     #   run: |
     #     pytest
+
+  lint:
+
+    runs-on: ubuntu-latest
+    continue-on-error: true
+    strategy:
+      fail-fast: false
+      # matrix:
+      #   python-version: ["3.7", "3.9", "3.10", "3.11"]
+
+    steps:
+    - uses: actions/checkout@v4
+    - name: Set up Python #${{ matrix.python-version }}
+      uses: actions/setup-python@v3
+      # with:
+      #   python-version: ${{ matrix.python-version }}
+    - name: Install dependencies
+      run: |
+        python -m pip install --upgrade pip
+        python -m pip install flake8 pytest
+        if [ -f requirements.txt ]; then pip install -r requirements.txt; fi
+        python -m pip install numpy scipy matplotlib scikit-image  # add versions to matrix
+    - name: Lint with flake8
+      # uses: 
+      # with:
+      # conclusion: neutral
+      run: |
+        # stop the build if there are Python syntax errors or undefined names
+        flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics
+        # exit-zero treats all errors as warnings. The GitHub editor is 127 chars wide
+        flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --statistics
+      if: always()
+    # - name: Linter result only for reference
+
+        
\ No newline at end of file

From 4d09fdfb24a8677c88f46c38a745fa1c3b3ffbdf Mon Sep 17 00:00:00 2001
From: Alho Markku J <markku.alho@helsinki.fi>
Date: Tue, 27 Aug 2024 15:00:23 +0300
Subject: [PATCH 14/19] Remove separate linter workflow, now in import test

---
 .github/workflows/python_lint.yml | 40 -------------------------------
 1 file changed, 40 deletions(-)
 delete mode 100644 .github/workflows/python_lint.yml

diff --git a/.github/workflows/python_lint.yml b/.github/workflows/python_lint.yml
deleted file mode 100644
index 9d9b19a5..00000000
--- a/.github/workflows/python_lint.yml
+++ /dev/null
@@ -1,40 +0,0 @@
-# This workflow will install Python dependencies, run tests and lint with a variety of Python versions
-# For more information see: https://docs.github.com/en/actions/automating-builds-and-tests/building-and-testing-python
-
-name: Python linting with flake8
-
-on:
-  push:
-    branches: [ master ]
-  pull_request:
-    branches: [ master ]
-  workflow_dispatch:
-
-jobs:
-  build:
-
-    runs-on: ubuntu-latest
-    strategy:
-      fail-fast: false
-      matrix:
-        python-version: ["3.7", "3.9", "3.10", "3.11"]
-
-    steps:
-    - uses: actions/checkout@v4
-    - name: Set up Python ${{ matrix.python-version }}
-      uses: actions/setup-python@v3
-      with:
-        python-version: ${{ matrix.python-version }}
-    - name: Install dependencies
-      run: |
-        python -m pip install --upgrade pip
-        python -m pip install flake8 pytest
-        if [ -f requirements.txt ]; then pip install -r requirements.txt; fi
-        python -m pip install numpy scipy matplotlib scikit-image  # add versions to matrix
-    - name: Lint with flake8
-      run: |
-        # stop the build if there are Python syntax errors or undefined names
-        flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics
-        # exit-zero treats all errors as warnings. The GitHub editor is 127 chars wide
-        flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --statistics
-

From bd22e1a26fb02333227ef466499666ec9ae1b4d1 Mon Sep 17 00:00:00 2001
From: Alho Markku J <markku.alho@helsinki.fi>
Date: Tue, 27 Aug 2024 15:00:48 +0300
Subject: [PATCH 15/19] Rename to test_python

---
 .github/workflows/{python_import.yml => test_python.yml} | 0
 1 file changed, 0 insertions(+), 0 deletions(-)
 rename .github/workflows/{python_import.yml => test_python.yml} (100%)

diff --git a/.github/workflows/python_import.yml b/.github/workflows/test_python.yml
similarity index 100%
rename from .github/workflows/python_import.yml
rename to .github/workflows/test_python.yml

From 6c7664f4d8c306cd2c6f54f4761c18974349528d Mon Sep 17 00:00:00 2001
From: Alho Markku J <markku.alho@helsinki.fi>
Date: Tue, 27 Aug 2024 15:08:07 +0300
Subject: [PATCH 16/19] Add latest test, matplotlib version matrix

---
 .github/workflows/test_python.yml | 29 ++++++++++++++++++++++++++---
 1 file changed, 26 insertions(+), 3 deletions(-)

diff --git a/.github/workflows/test_python.yml b/.github/workflows/test_python.yml
index 135f8dee..fb285878 100644
--- a/.github/workflows/test_python.yml
+++ b/.github/workflows/test_python.yml
@@ -11,13 +11,36 @@ on:
   workflow_dispatch:
 
 jobs:
-  import:
+
+  latest:
+
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+
+    steps:
+    - uses: actions/checkout@v4
+    - name: Set up Python #${{ matrix.python-version }}
+      uses: actions/setup-python@v3
+      # with:
+      #   python-version: ${{ matrix.python-version }}
+    - name: Install dependencies
+      run: |
+        python -m pip install --upgrade pip
+        python -m pip install pytest
+        if [ -f requirements.txt ]; then pip install -r requirements.txt; fi
+        python -m pip install numpy scipy matplotlib scikit-image # add versions to matrix
+    - name: Trial imports
+      run: python -c 'import pytools as pt'
+
+  import-matrix:
 
     runs-on: ubuntu-latest
     strategy:
       fail-fast: false
       matrix:
         python-version: ["3.7", "3.9", "3.10", "3.11"]
+        matplotlib-version: ["3.5", "3.6", "3.8","3.9"]
 
     steps:
     - uses: actions/checkout@v4
@@ -30,7 +53,7 @@ jobs:
         python -m pip install --upgrade pip
         python -m pip install pytest
         if [ -f requirements.txt ]; then pip install -r requirements.txt; fi
-        python -m pip install numpy scipy matplotlib scikit-image # add versions to matrix
+        python -m pip install numpy scipy matplotlib==${{ matrix.matplotlib-version }} scikit-image # add versions to matrix
     - name: Trial imports
       run: python pytools.py
     # - name: Test with pytest
@@ -48,7 +71,7 @@ jobs:
 
     steps:
     - uses: actions/checkout@v4
-    - name: Set up Python #${{ matrix.python-version }}
+    - name: Set up Python  # ${{ matrix.python-version }}
       uses: actions/setup-python@v3
       # with:
       #   python-version: ${{ matrix.python-version }}

From 3694b51c77ba3d3ebed96041ccf517f81f9dc562 Mon Sep 17 00:00:00 2001
From: Alho Markku J <markku.alho@helsinki.fi>
Date: Tue, 27 Aug 2024 15:11:48 +0300
Subject: [PATCH 17/19] Matplotlib version testing is tedious, disable for now
 (needs to be tailored per python-version?)

---
 .github/workflows/test_python.yml | 20 +++++---------------
 1 file changed, 5 insertions(+), 15 deletions(-)

diff --git a/.github/workflows/test_python.yml b/.github/workflows/test_python.yml
index fb285878..66a23dc6 100644
--- a/.github/workflows/test_python.yml
+++ b/.github/workflows/test_python.yml
@@ -40,7 +40,7 @@ jobs:
       fail-fast: false
       matrix:
         python-version: ["3.7", "3.9", "3.10", "3.11"]
-        matplotlib-version: ["3.5", "3.6", "3.8","3.9"]
+        # matplotlib-version: ["3.3.0", "3.5.3"]
 
     steps:
     - uses: actions/checkout@v4
@@ -53,12 +53,10 @@ jobs:
         python -m pip install --upgrade pip
         python -m pip install pytest
         if [ -f requirements.txt ]; then pip install -r requirements.txt; fi
-        python -m pip install numpy scipy matplotlib==${{ matrix.matplotlib-version }} scikit-image # add versions to matrix
+        python -m pip install numpy scipy matplotlib scikit-image # add versions to matrix
     - name: Trial imports
       run: python pytools.py
-    # - name: Test with pytest
-    #   run: |
-    #     pytest
+
 
   lint:
 
@@ -66,15 +64,11 @@ jobs:
     continue-on-error: true
     strategy:
       fail-fast: false
-      # matrix:
-      #   python-version: ["3.7", "3.9", "3.10", "3.11"]
 
     steps:
     - uses: actions/checkout@v4
-    - name: Set up Python  # ${{ matrix.python-version }}
+    - name: Set up Python 
       uses: actions/setup-python@v3
-      # with:
-      #   python-version: ${{ matrix.python-version }}
     - name: Install dependencies
       run: |
         python -m pip install --upgrade pip
@@ -82,15 +76,11 @@ jobs:
         if [ -f requirements.txt ]; then pip install -r requirements.txt; fi
         python -m pip install numpy scipy matplotlib scikit-image  # add versions to matrix
     - name: Lint with flake8
-      # uses: 
-      # with:
-      # conclusion: neutral
       run: |
         # stop the build if there are Python syntax errors or undefined names
         flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics
         # exit-zero treats all errors as warnings. The GitHub editor is 127 chars wide
         flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --statistics
-      if: always()
-    # - name: Linter result only for reference
+
 
         
\ No newline at end of file

From 0192f24eecf6b16479b8640e1abed51342c17126 Mon Sep 17 00:00:00 2001
From: Alho Markku J <markku.alho@helsinki.fi>
Date: Tue, 27 Aug 2024 15:13:35 +0300
Subject: [PATCH 18/19] import as passed command for import matrix as well

---
 .github/workflows/test_python.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/test_python.yml b/.github/workflows/test_python.yml
index 66a23dc6..1f309fc2 100644
--- a/.github/workflows/test_python.yml
+++ b/.github/workflows/test_python.yml
@@ -55,7 +55,7 @@ jobs:
         if [ -f requirements.txt ]; then pip install -r requirements.txt; fi
         python -m pip install numpy scipy matplotlib scikit-image # add versions to matrix
     - name: Trial imports
-      run: python pytools.py
+      run: python -c 'import pytools as pt'
 
 
   lint:

From 6110b8d0134c5712c9fda35e7f16b7b48995418a Mon Sep 17 00:00:00 2001
From: Alho Markku J <markku.alho@helsinki.fi>
Date: Tue, 27 Aug 2024 15:14:55 +0300
Subject: [PATCH 19/19] fix newline

---
 .github/workflows/test_python.yml | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/.github/workflows/test_python.yml b/.github/workflows/test_python.yml
index 1f309fc2..9ceb6bc3 100644
--- a/.github/workflows/test_python.yml
+++ b/.github/workflows/test_python.yml
@@ -81,6 +81,3 @@ jobs:
         flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics
         # exit-zero treats all errors as warnings. The GitHub editor is 127 chars wide
         flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --statistics
-
-
-        
\ No newline at end of file