Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Remove sys_ptrace dependency #264

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Remove sys_ptrace dependency #264

wants to merge 18 commits into from

Conversation

pingsutw
Copy link
Member

@pingsutw pingsutw commented May 11, 2022

TL;DR

  • Remove sys_ptrace
  • Use file_watcher by default if using copilot
  • Update raw container task phase

Declare the task as a failure when the raw container is failing, and the tasks succeed if both the raw and the sidecar containers succeed

The reason is that sidecar run forever if the raw container fails because the sidecar container keeps waiting for the raw container to write the SUCCESS file to the local disk. As a result, the task status was always "running".

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

flyteorg/flyte#2162

Follow-up issue

NA

@codecov
Copy link

codecov bot commented May 11, 2022

Codecov Report

Merging #264 (6615886) into master (e2971ef) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #264      +/-   ##
==========================================
+ Coverage   63.01%   63.03%   +0.02%     
==========================================
  Files         142      142              
  Lines        8968     8973       +5     
==========================================
+ Hits         5651     5656       +5     
  Misses       2796     2796              
  Partials      521      521              
Flag Coverage Δ
unittests 62.38% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
go/tasks/pluginmachinery/flytek8s/config/config.go 50.00% <ø> (ø)
go/tasks/pluginmachinery/flytek8s/copilot.go 91.76% <100.00%> (-0.24%) ⬇️
go/tasks/plugins/array/k8s/subtask_exec_context.go 81.52% <100.00%> (-0.20%) ⬇️
go/tasks/plugins/k8s/pod/container.go 83.33% <100.00%> (+11.90%) ⬆️
go/tasks/plugins/k8s/pod/plugin.go 85.39% <100.00%> (+1.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2971ef...6615886. Read the comment docs.

@pingsutw pingsutw changed the title Remove sys_ptrace dependency [WIP] Remove sys_ptrace dependency May 13, 2022
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
@pingsutw pingsutw changed the title [WIP] Remove sys_ptrace dependency Remove sys_ptrace dependency May 18, 2022
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant