Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Migrate ArrayJob to use TaskTemplate Config and deprecate ArrayJob proto #229

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

pingsutw
Copy link
Member

TL;DR

Migrate ArrayJob to use TaskTemplate Config and deprecate ArrayJob proto
flyteorg/flyte#1791

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

fixes https://github.com/flyteorg/flyte/issues/

Follow-up issue

NA

Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
@codecov
Copy link

codecov bot commented Dec 22, 2021

Codecov Report

Merging #229 (0dd93c2) into master (ac44eae) will increase coverage by 0.12%.
The diff coverage is 80.32%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #229      +/-   ##
==========================================
+ Coverage   62.97%   63.09%   +0.12%     
==========================================
  Files         142      143       +1     
  Lines        8889     8894       +5     
==========================================
+ Hits         5598     5612      +14     
+ Misses       2789     2779      -10     
- Partials      502      503       +1     
Flag Coverage Δ
unittests 62.76% <78.57%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
go/tasks/plugins/array/array_tests_base.go 0.00% <0.00%> (ø)
go/tasks/plugins/array/k8s/transformer.go 77.27% <50.00%> (-0.51%) ⬇️
go/tasks/plugins/array/core/state.go 74.07% <94.28%> (+2.97%) ⬆️
go/tasks/plugins/array/awsbatch/executor.go 40.56% <100.00%> (ø)
go/tasks/plugins/array/catalog.go 46.88% <100.00%> (-1.70%) ⬇️
go/tasks/plugins/array/core/array_job.go 100.00% <100.00%> (ø)
go/tasks/plugins/array/inputs.go 83.33% <100.00%> (ø)
go/tasks/plugins/array/outputs.go 72.18% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac44eae...0dd93c2. Read the comment docs.

Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants