Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy ca-certificates from micromamba #2923

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

thomasjpfan
Copy link
Member

Why are the changes needed?

For macOS using Rosetta, sometimes installing ca-certificates or running update-ca-certificates can run into errors.

What changes were proposed in this pull request?

  1. With this PR, we copy over the certificates from the micromamba image, which avoids installing ca-certificate and running update-ca-certificates all together.
  2. Without the apt command + update-ca-certifcates the builds are faster.

How was this patch tested?

I ran a simple script with the sandbox:

from flytekit import ImageSpec, task

image_spec = ImageSpec(
    name="flytekit-check-2",
    packages=["numpy"],
    registry="localhost:30000",
)


@task(container_image=image_spec)
def wow() -> float:
    import numpy as np
    return np.ones((30, 10)).sum().item()

Copy link
Collaborator

@eapolinario eapolinario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm all for more reproducibility and better perf.

@thomasjpfan thomasjpfan merged commit e19bbcc into flyteorg:master Nov 14, 2024
103 of 105 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants