Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip - Carry over task args in flytekit plugins decorators #2911

Open
wants to merge 28 commits into
base: master
Choose a base branch
from

Conversation

eapolinario
Copy link
Collaborator

Experiment to carry over task args from flytekit plugin decorators.

fiedlerNr9 and others added 28 commits November 6, 2024 09:18
Signed-off-by: Jan Fiedler <[email protected]>
Signed-off-by: Jan Fiedler <[email protected]>
Signed-off-by: Jan Fiedler <[email protected]>
Signed-off-by: Jan Fiedler <[email protected]>
Signed-off-by: Jan Fiedler <[email protected]>
Signed-off-by: Jan Fiedler <[email protected]>
Signed-off-by: Jan Fiedler <[email protected]>
Signed-off-by: Jan Fiedler <[email protected]>
Signed-off-by: Jan Fiedler <[email protected]>
Signed-off-by: Jan Fiedler <[email protected]>
Signed-off-by: Jan Fiedler <[email protected]>
Signed-off-by: Jan Fiedler <[email protected]>
Signed-off-by: Jan Fiedler <[email protected]>
Signed-off-by: Jan Fiedler <[email protected]>
Signed-off-by: Jan Fiedler <[email protected]>
Signed-off-by: Jan Fiedler <[email protected]>
Signed-off-by: Jan Fiedler <[email protected]>
Signed-off-by: Jan Fiedler <[email protected]>
Signed-off-by: Jan Fiedler <[email protected]>
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 76.68%. Comparing base (3541f5e) to head (fe64f84).

Files with missing lines Patch % Lines
flytekit/core/task.py 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@                  Coverage Diff                   @@
##           add-memray-plugin    #2911       +/-   ##
======================================================
+ Coverage              43.89%   76.68%   +32.79%     
======================================================
  Files                    199      219       +20     
  Lines                  20820    21426      +606     
  Branches                2676     2651       -25     
======================================================
+ Hits                    9138    16430     +7292     
+ Misses                 11448     4241     -7207     
- Partials                 234      755      +521     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from add-memray-plugin to master November 12, 2024 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants