Skip to content
This repository has been archived by the owner on Mar 1, 2024. It is now read-only.

Require services property on fly_machine #169

Open
oscarhermoso opened this issue Apr 30, 2023 · 0 comments · May be fixed by #238
Open

Require services property on fly_machine #169

oscarhermoso opened this issue Apr 30, 2023 · 0 comments · May be fixed by #238

Comments

@oscarhermoso
Copy link

oscarhermoso commented Apr 30, 2023

Currently, you can deploy a fly_machine without any services:

resource "fly_machine" "app" {
  cpus     = 1
  memorymb = 256

  app    = fly_app.app.name
  region = var.region
  name   = "${fly_app.app.name}-${var.region}"
  image  = var.image
  env    = var.env

  # services = var.services # <-- missing
}

Although most people would not make this mistake, it became an issue when I was extracting a module for our app

Ideally it would be a required field, possibly allowing an empty list, unless there is some reason for it to be optional that I have not considered.

@sorenhansendk sorenhansendk linked a pull request Sep 2, 2023 that will close this issue
@andrewbaxter andrewbaxter mentioned this issue Dec 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant