Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(network_info_plus): Add Swift Package Manager support #3172

Merged
merged 6 commits into from
Oct 17, 2024

Conversation

charafau
Copy link
Contributor

ref: #3152

Another spm support

@miquelbeltran miquelbeltran changed the title feat: [Network info] Add Swift Package Manager support for Network info spm feat(network_info_plus): Add Swift Package Manager support for Network info spm Aug 12, 2024
Copy link
Member

@miquelbeltran miquelbeltran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, still want to test on my device before approval and merge

@vbuberen vbuberen changed the title feat(network_info_plus): Add Swift Package Manager support for Network info spm feat(network_info_plus): Add Swift Package Manager support Aug 13, 2024
Copy link
Collaborator

@vbuberen vbuberen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the privacy manifest location and declaration for MacOS.
Unfortunately, I currently don't have a personal account with Wi-Fi capability, so couldn't test this one, but considering that all other PRs on this topic are alright, I believe we are good to go.

@vbuberen vbuberen merged commit bcf7a5b into fluttercommunity:main Oct 17, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants