fix(battery_plus): Fix type conversion #3153
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Makes sense! can you rebase this PR to #3103 ? I'd also prefer if the PR only contained the Thanks! |
koji-1009
force-pushed
the
fix/wasm_type_error
branch
from
3f6a99f
to
ca2bca5
Compare
koji-1009
changed the base branch from
main
to
dependabot/pub/packages/battery_plus/battery_plus/web-1.0.0
|
@miquelbeltran |
|
Thank you! I will merge this one once #3103 lands |
miquelbeltran
approved these changes
Aug 8, 2024
miquelbeltran
deleted the branch
fluttercommunity:dependabot/pub/packages/battery_plus/battery_plus/web-1.0.0
|
ugh why is closed... |
|
For some reason GH closed this automatically instead of changing the target to |
|
No problem! Thanks Marge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When wasm is used, there is a complete distinction between double and int. For this reason, casting a double type to an int type with
aswill cause a crash in the wasm environment. Fix this problem by changing fromas inttotoInt().flutter/flutter#146231
Starting with flutter 3.24, the
flutter run --wasmcommand makes it easy to try out the wasm version of the app at local.Related Issues
Checklist
CHANGELOG.mdnor the plugin version inpubspec.yamlfiles.flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
!in the title as explained in Conventional Commits).