Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement wifi-only downloads for iOS #768

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Implement wifi-only downloads for iOS #768

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
df9ae16
Correctly read the error/success codes
lyio Nov 24, 2022
1ccd752
Add schema migrations on iOS
lyio Nov 24, 2022
54ac602
#408 Add DB column for `allow_cellular` on iOS
lyio Nov 24, 2022
7fec9a6
#408 Use different NSURLSessions to prevent downloads via cellular data
lyio Nov 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 22 additions & 17 deletions example/lib/home_page.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ class _MyHomePageState extends State<MyHomePage> {
late bool _showContent;
late bool _permissionReady;
late bool _saveInPublicStorage;
late bool _allowCellular;
late String _localPath;
final ReceivePort _port = ReceivePort();

Expand All @@ -42,6 +43,7 @@ class _MyHomePageState extends State<MyHomePage> {
_showContent = false;
_permissionReady = false;
_saveInPublicStorage = false;
_allowCellular = true;

_prepare();
}
Expand Down Expand Up @@ -98,8 +100,7 @@ class _MyHomePageState extends State<MyHomePage> {
'task ($id) is in status ($status) and process ($progress)',
);

IsolateNameServer.lookupPortByName('downloader_send_port')
?.send([id, status, progress]);
IsolateNameServer.lookupPortByName('downloader_send_port')?.send([id, status, progress]);
}

Widget _buildDownloadList() {
Expand All @@ -117,13 +118,23 @@ class _MyHomePageState extends State<MyHomePage> {
const Text('Save in public storage'),
],
),
Row(
children: [
Checkbox(
value: _allowCellular,
onChanged: (newValue) {
setState(() => _allowCellular = newValue ?? true);
},
),
const Text('Allow download via cellular data'),
],
),
..._items.map(
(item) {
final task = item.task;
if (task == null) {
return Container(
padding:
const EdgeInsets.symmetric(horizontal: 16, vertical: 8),
padding: const EdgeInsets.symmetric(horizontal: 16, vertical: 8),
child: Text(
item.name!,
style: const TextStyle(
Expand Down Expand Up @@ -154,8 +165,7 @@ class _MyHomePageState extends State<MyHomePage> {
_pauseDownload(task);
} else if (task.status == DownloadTaskStatus.paused) {
_resumeDownload(task);
} else if (task.status == DownloadTaskStatus.complete ||
task.status == DownloadTaskStatus.canceled) {
} else if (task.status == DownloadTaskStatus.complete || task.status == DownloadTaskStatus.canceled) {
_delete(task);
} else if (task.status == DownloadTaskStatus.failed) {
_retryDownload(task);
Expand Down Expand Up @@ -217,6 +227,7 @@ class _MyHomePageState extends State<MyHomePage> {
headers: {'auth': 'test_for_sql_encoding'},
savedDir: _localPath,
saveInPublicStorage: _saveInPublicStorage,
allowCellular: _allowCellular,
);
}

Expand Down Expand Up @@ -300,8 +311,7 @@ class _MyHomePageState extends State<MyHomePage> {
}

_tasks!.addAll(
DownloadItems.images
.map((image) => TaskInfo(name: image.name, link: image.url)),
DownloadItems.images.map((image) => TaskInfo(name: image.name, link: image.url)),
);

_items.add(ItemHolder(name: 'Images'));
Expand All @@ -311,8 +321,7 @@ class _MyHomePageState extends State<MyHomePage> {
}

_tasks!.addAll(
DownloadItems.videos
.map((video) => TaskInfo(name: video.name, link: video.url)),
DownloadItems.videos.map((video) => TaskInfo(name: video.name, link: video.url)),
);

_items.add(ItemHolder(name: 'Videos'));
Expand All @@ -322,8 +331,7 @@ class _MyHomePageState extends State<MyHomePage> {
}

_tasks!.addAll(
DownloadItems.apks
.map((video) => TaskInfo(name: video.name, link: video.url)),
DownloadItems.apks.map((video) => TaskInfo(name: video.name, link: video.url)),
);

_items.add(ItemHolder(name: 'APKs'));
Expand Down Expand Up @@ -374,8 +382,7 @@ class _MyHomePageState extends State<MyHomePage> {
externalStorageDirPath = directory?.path;
}
} else if (Platform.isIOS) {
externalStorageDirPath =
(await getApplicationDocumentsDirectory()).absolute.path;
externalStorageDirPath = (await getApplicationDocumentsDirectory()).absolute.path;
}
return externalStorageDirPath;
}
Expand Down Expand Up @@ -412,9 +419,7 @@ class _MyHomePageState extends State<MyHomePage> {
return const Center(child: CircularProgressIndicator());
}

return _permissionReady
? _buildDownloadList()
: _buildNoPermissionWarning();
return _permissionReady ? _buildDownloadList() : _buildNoPermissionWarning();
},
),
);
Expand Down
Loading