-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Determine which DevTools windows should allow multiple tabs per tool window #7634
Comments
Correct: Inspector tool window - Multiple tabs possible, one for each app Incorrect: Deep links - Only one tab, Should not be associated with an app, i.e. VM service URI should not be appended All of these follow the multiple tabs pattern and can connect to a running app's VM service. |
What type of app did you run? You may be hitting this: flutter/devtools#8228. That URI looks correct to me. |
Ah yes, I am hitting that problem. I'll test this out on an Android device instead. |
At the moment, only the inspector tool window properly supports multiple apps running at once. I would guess the prioritization of supporting multiple apps for the other tool windows is around a P3. If users mention this, we could reprioritize. The inspector tool window support for multiple apps was a user-contributed change, so potentially someone else could work on doing the same for other windows if it's important to them. CC @jwren |
Multiple tabs per tool window will appear if there are multiple apps running. This is appropriate for the inspector tool window since each app running could have different widget trees. But I don't think this applies to every page of DevTools, so an audit is appropriate here.
Inspector tool window:
Other DevTools (performance, CPU profiler, memory, etc):
Deep links:
Extensions:
@kenzieschmoll is the above correct? I don't know if we need to prioritize cleaning up multi-app support immediately (as it doesn't seem to be used much), but currently I suspect deep links and extensions should be changed to not append VM service URI.
The text was updated successfully, but these errors were encountered: