Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine which DevTools windows should allow multiple tabs per tool window #7634

Open
helin24 opened this issue Aug 29, 2024 · 5 comments
Open
Assignees
Milestone

Comments

@helin24
Copy link
Member

helin24 commented Aug 29, 2024

Multiple tabs per tool window will appear if there are multiple apps running. This is appropriate for the inspector tool window since each app running could have different widget trees. But I don't think this applies to every page of DevTools, so an audit is appropriate here.

Inspector tool window:

  • Multiple tabs possible, one for each app

Other DevTools (performance, CPU profiler, memory, etc):

  • Multiple tabs possible, one for each app

Deep links:

  • Only one tab
  • Should not be associated with an app, i.e. VM service URI should not be appended

Extensions:

  • Only one tab
  • Should not be associated with an app, i.e. VM service URI should not be appended

@kenzieschmoll is the above correct? I don't know if we need to prioritize cleaning up multi-app support immediately (as it doesn't seem to be used much), but currently I suspect deep links and extensions should be changed to not append VM service URI.

@helin24 helin24 self-assigned this Aug 29, 2024
@helin24 helin24 added this to the M82 milestone Aug 29, 2024
@kenzieschmoll
Copy link
Member

kenzieschmoll commented Aug 30, 2024

Correct: Inspector tool window - Multiple tabs possible, one for each app
Correct: Other DevTools (performance, CPU profiler, memory, etc) - Multiple tabs possible, one for each app

Incorrect: Deep links - Only one tab, Should not be associated with an app, i.e. VM service URI should not be appended
Incorrect: Extensions - Only one tab, Should not be associated with an app, i.e. VM service URI should not be appended

All of these follow the multiple tabs pattern and can connect to a running app's VM service.

@helin24
Copy link
Member Author

helin24 commented Aug 30, 2024

Okay, thanks for clarifying!

This is an example of what we might open for the deep links tool window once an app starts running: http://127.0.0.1:9104/deep-links?ide=Android-Studio&backgroundColor=2b2d30&theme=dark&embedMode=one&fontSize=13.0&ideFeature=toolWindow&uri=http://127.0.0.1:50501/IyPoHwyop3g=

But DevTools then opens to this error:
Screenshot 2024-08-30 at 2 04 04 PM

Is that URI param incorrect?

@kenzieschmoll
Copy link
Member

What type of app did you run? You may be hitting this: flutter/devtools#8228. That URI looks correct to me.

@helin24
Copy link
Member Author

helin24 commented Sep 3, 2024

What type of app did you run? You may be hitting this: flutter/devtools#8228. That URI looks correct to me.

Ah yes, I am hitting that problem. I'll test this out on an Android device instead.

@helin24
Copy link
Member Author

helin24 commented Oct 4, 2024

At the moment, only the inspector tool window properly supports multiple apps running at once. I would guess the prioritization of supporting multiple apps for the other tool windows is around a P3. If users mention this, we could reprioritize. The inspector tool window support for multiple apps was a user-contributed change, so potentially someone else could work on doing the same for other windows if it's important to them.

CC @jwren

@helin24 helin24 modified the milestones: M82, Backlog, On Deck Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants