Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not reload Tool Windows when theme is changed #7626

Closed
kenzieschmoll opened this issue Aug 22, 2024 · 3 comments
Closed

Do not reload Tool Windows when theme is changed #7626

kenzieschmoll opened this issue Aug 22, 2024 · 3 comments
Assignees
Labels
devtools-integration Related to the integration with Dart DevTools
Milestone

Comments

@kenzieschmoll
Copy link
Member

Performing a full reload of the DevTools tool window when the IDE theme is changed is disruptive to the user's workflow and may cause them to lose any debugging data they were looking at before the theme change.

Now that we have DTD to communicate over, we should send an event when the IDE theme changes that DevTools can listen for. DevTools can then update itself for the new IDE theme values.

@helin24
Copy link
Member

helin24 commented Aug 29, 2024

There may be some situations where DTD isn't available, e.g. internal usages. Do you have an opinion on whether we should continue to update theme with a refresh or ignore theme changes in those cases? (or something else)

@kenzieschmoll
Copy link
Member Author

If DTD is not available, I recommend we do not update the theme. Having a mismatched theme is a better result than the user potentially losing state in their tool if we force refresh IMO.

@helin24
Copy link
Member

helin24 commented Oct 4, 2024

With the latest changes to DevTools this issue is now resolved

@helin24 helin24 closed this as completed Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devtools-integration Related to the integration with Dart DevTools
Projects
None yet
Development

No branches or pull requests

2 participants