Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't use separator for gcode macros #1483

Merged
merged 1 commit into from
Aug 15, 2024
Merged

fix: don't use separator for gcode macros #1483

merged 1 commit into from
Aug 15, 2024

Conversation

pedrolamas
Copy link
Member

@pedrolamas pedrolamas commented Aug 15, 2024 •
edited
Loading

For any Gn or Mn macro (where n is one of more digits), we will not add = as a parameter separator as these are considered overrides of classic G-code commands

Resolves #1481

@pedrolamas pedrolamas added the GH - Bug Something isn't working label Aug 15, 2024
@pedrolamas pedrolamas added this to the 1.30.4 milestone Aug 15, 2024
@pedrolamas pedrolamas merged commit 7ec4626 into fluidd-core:develop Aug 15, 2024
6 checks passed
@pedrolamas pedrolamas deleted the pedrolamas/gcode-macro-separator branch August 15, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
GH - Bug Something isn't working
Projects
None yet
Milestone
1.30.4
Development

Successfully merging this pull request may close these issues.

Traditional Gcode uses = for parameters
1 participant
@pedrolamas