feat: improve fan and outputs panel layout #1470
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HelgeKeck
changed the title
|
|
|
I'm not sure about the "controllable fans" label, because all fans are controllable right. Not sure yet what to suggest either. |
its probably not the correct word i choosed. but i think having them grouped by fans that the user can control and other fans is nebeficial, especially if you have mroe than one fan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: My feature.
This PR improves tha panel layout for the fans and outputs, it also groups the devices and makes the collapseable
Some description.
Would be nice to make the collapsed state persistent. some help would be appreciated
Signed-off-by: Helge Keck [email protected]