feat: show warning for Trinamic OTPW flag #1448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matmen
previously approved these changes
Jun 11, 2024
src/store/helpers.ts
Outdated
|
|
||
| const notification: AppPushNotification = { | ||
| id: `${item}-otpw`, | ||
| title: `TMC '${name}' is over-heating`, |
There was a problem hiding this comment.
I feel like this should be something like Stepper driver 'name' is over-heating, chances are end users don't know what TMC means
There was a problem hiding this comment.
Good point, I updated the description to your suggestion!
Signed-off-by: Pedro Lamas <[email protected]>
pedrolamas
force-pushed
the
pedrolamas/tmc-otpw-warning
branch
from
064206e
to
39f74c5
Compare
|
Awesome stuff, greatly appreciate the work you put into fluidd! |
|
might have even saved my 5160s! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shows a notification message when any
TMCxxxxdriver reports anotpwflag (over-temperature pre warning)The link on the notification is currently pointing to https://www.klipper3d.org/TMC_Drivers.html#tmc-reports-error-ot1overtemperror
Resolves #1105