Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds Danger Klipper config support #1446

Conversation

pedrolamas
Copy link
Member

Checks if we are running on Danger-Klipper and if so, use its website for documentation.

Note: given the popularity of Klipper, there are now quite a few "flavors" proliferating, but we have no plans to add indiscriminate support to any of these Klipper forks.

However, Danger Klipper is now the main Klipper fork and is gaining significant traction, hence why we are specifically adding config support for it here.

Resolves #1349

@pedrolamas pedrolamas added the FR - Enhancement New feature or request label Jun 3, 2024
@pedrolamas pedrolamas added this to the 1.30.1 milestone Jun 3, 2024
@pedrolamas pedrolamas requested a review from matmen June 3, 2024 13:51
@pedrolamas pedrolamas force-pushed the pedrolamas/danger-klipper-config-support branch from 4cc2116 to ce2a1ba Compare June 3, 2024 13:57
Copy link
Member

@matmen matmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pedrolamas pedrolamas merged commit 0c4f79e into fluidd-core:develop Jun 3, 2024
4 checks passed
@pedrolamas pedrolamas deleted the pedrolamas/danger-klipper-config-support branch June 3, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FR - Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change Configuration Reference Page Based on Klipper forks
2 participants