Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]cacheworkerset interface #4389

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

zwbrealm
Copy link

@zwbrealm zwbrealm commented Nov 5, 2024

Ⅰ. Describe what this PR does

1.在alluxio runtime type中增加workerType字段,用来指示worker类型(STS,ASTS,DaemonSet)
2.增加cacheworkerset 定义以及相关属性的GET/SET操作(pkg/types/cacheworkerset/interface.go)
3.引入了openkruise依赖后,根据它的特性,只需要手动对work pod的label进行patch SpecifiedDeleteKey = "apps.kruise.io/specified-delete",且这些worker pod被openkruise advanced statefulset接管,那么就可以做到指定该pod下线了。

Ⅱ. Does this pull request fix one issue?

fixes #XXXX

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link

fluid-e2e-bot bot commented Nov 5, 2024

Hi @zwbrealm. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

fluid-e2e-bot bot commented Nov 5, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ronggu for approval by writing /assign @ronggu in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

sonarcloud bot commented Nov 7, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant