Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fluent 6.0: buttons inside drop downs don't seem to work when using ClosePopupOnMouseDown #517

Closed
GeertvanHorrik opened this issue Feb 7, 2018 · 9 comments
Closed

Fluent 6.0: buttons inside drop downs don't seem to work when using ClosePopupOnMouseDown #517

GeertvanHorrik opened this issue Feb 7, 2018 · 9 comments
Assignees
@batzen
Labels
Bug 🐞
Milestone
6.1.0

Comments

@GeertvanHorrik
Copy link
Contributor

We have this issue now in a component we haven't changed in a while. Not sure if this is being caused by Fluent 6.0, will investigate and fill up this ticket.
@GeertvanHorrik
Copy link
Contributor Author

I think I introduced this in #5

@GeertvanHorrik
Copy link
Contributor Author

I disabled hiding for now, as you can see the buttons don't respond to anything. Will try to investigate why.

fluent_ribbon_button_issue

@GeertvanHorrik
Copy link
Contributor Author

Can repro in the Fluent.Ribbon example repository.

GeertvanHorrik added a commit to GeertvanHorrik/Fluent.Ribbon that referenced this issue Feb 7, 2018
@GeertvanHorrik
Create test case & repro for fluentribbon#517
37f3a2e
@GeertvanHorrik
Copy link
Contributor Author

See #520 for further details.

@batzen
Copy link
Member

batzen commented Feb 7, 2018

Removing ClosePopupOnMouseDown seems to work on my machine.
Will have a look at why ClosePopupOnMouseDown prevents the click from reaching the button.

@batzen
Copy link
Member

batzen commented Feb 7, 2018 •
edited
Loading

It's caused by cccc1ca and e.Handled = false.
Removing e.Handled = false fixes the issue.
Could you please confirm if this fixes the issue for you too?

@batzen batzen added the Bug 🐞 label Feb 7, 2018
@batzen batzen self-assigned this Feb 7, 2018
@batzen batzen added this to the 6.1.0 milestone Feb 7, 2018
@GeertvanHorrik
Copy link
Contributor Author

Very weird, this code has always worked for us, but will test now.

@GeertvanHorrik
Copy link
Contributor Author

Fix confirmed. Do you have an ETA for 6.1?

@batzen batzen changed the title Fluent 6.0: buttons inside drop downs don't seem to work Fluent 6.0: buttons inside drop downs don't seem to work when using ClosePopupOnMouseDown Feb 8, 2018
@batzen batzen closed this as completed in 5d7f34b Feb 8, 2018
@batzen
Copy link
Member

batzen commented Feb 8, 2018

Maybe during the weekend.
Highly depends on how many issues are found till then. ;-)

batzen added a commit that referenced this issue Feb 15, 2018
@batzen
Fixes #517 by removing e.Handled = false in OnDropDownPopupMouseDown
74b17a2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@batzen batzen

Labels
Bug 🐞
Projects
None yet
Milestone
6.1.0
Development

No branches or pull requests
2 participants
@GeertvanHorrik @batzen