Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Rezising at Fluent:RibbonContextualTabGroup at Version 5.0 #430

Closed
langeth opened this issue May 4, 2017 · 27 comments
Closed

No Rezising at Fluent:RibbonContextualTabGroup at Version 5.0 #430

langeth opened this issue May 4, 2017 · 27 comments
Assignees
Milestone

Comments

@langeth
Copy link

langeth commented May 4, 2017

The Fluent:RibbonContextualTabGroup do not Rezise like Fluent:RibbonTabItem

At Fullscreen the RibbonContextualTabGroup not following the RibbonTabItems

Environment

  • Fluent.Ribbon v5.0.1
  • Theme ? (not needed in version 5.0 and upwards)
  • Windows 10
  • .NET Framework 4.6
@batzen
Copy link
Member

batzen commented May 4, 2017

Will have a look at this as soon as i can. Which will, most probably, be next week.

@langeth
Copy link
Author

langeth commented May 5, 2017 via email

@batzen
Copy link
Member

batzen commented May 5, 2017

I tried to reproduce your issue from what i understood from your first issue but did not succeed in v6.0.
Could you add a image/video/gif showing the exact issue you are having?

Regarding your second issue:
The images are missing from your answer.
Does that still happen in version 5.0? I fixed a few rendering/layout issues in the QuickAccess area.

German:
Ich antworte hier auf Englisch, damit alle anderen unsere Konversation ebenfalls nachvollziehen können. Nicht falsch verstehen. ;-)

@langeth
Copy link
Author

langeth commented May 8, 2017

Picture 1 with 4 Icons: blue.xaml
image
Picture 2 with 3 Icons: generic.xaml - missing 1 Icon - it is at >> sign.
image

@batzen
Copy link
Member

batzen commented May 8, 2017

Ok, one icon more or less might be caused by different styles and thus different space requirements.
But the blank space on the left in Picture 2 looks strange.
Does this still look the same in version 5.0 or 6.0?

The Office 2010 theme is gone in 5.0, by the way.

@langeth
Copy link
Author

langeth commented May 8, 2017

The left icon i deleted, so this is not the problem.

@langeth
Copy link
Author

langeth commented May 8, 2017

I only tested it with version 5.0.

@langeth
Copy link
Author

langeth commented May 8, 2017

The problems with Icon 3 or 4 are fixed with version 6.0.

@langeth
Copy link
Author

langeth commented May 8, 2017

Tested with Version 6.0
Ribbon at Normal Windowmode:
image
Ribbon at Fullscreen Windowmode:
image

@batzen
Copy link
Member

batzen commented May 9, 2017

So there is only your fullscreen issue.
I can't reproduce the issue using the showcase application.
Is there any chance you can provide a repro for that?

@batzen batzen self-assigned this May 9, 2017
@langeth
Copy link
Author

langeth commented May 10, 2017

I use a Dockpanel around the Fluent:Ribbon/
<DockPanel.LayoutTransform>

</DockPanel.LayoutTransform>

and at Fullscreen i set ScaleX/Y to 1.6

@batzen
Copy link
Member

batzen commented May 10, 2017

Ah, ok. Will try to reproduce the issue tomorrow using your hint.

@batzen
Copy link
Member

batzen commented May 11, 2017

Ok, i can reproduce it. But it's not only the ContextualTabGroup not being scaled. It's the whole titlebar.

@batzen
Copy link
Member

batzen commented May 11, 2017

The same problem exists in the sample application when you zoom it.
Will have a look at this.

@batzen
Copy link
Member

batzen commented May 11, 2017

Ah. The problem is that the zoom only applied to the content of the window.
That's because the window has a template which contains the titlebar etc. and a contentpresenter which is where your dockpanel is placed.

@batzen
Copy link
Member

batzen commented May 11, 2017

Forwarding the LayoutTransform to the template-parts seems impossible in stable manner.
The easiest way to get the whole window content being zoomed is

        public TestWindow()
        {
            this.InitializeComponent();

            this.Loaded += this.TestWindow_Loaded;
        }

        private void TestWindow_Loaded(object sender, RoutedEventArgs e)
        {
            ((FrameworkElement)VisualTreeHelper.GetChild(this, 0)).LayoutTransform = new ScaleTransform(1.6, 1.6);
        }

@batzen
Copy link
Member

batzen commented May 17, 2017

@langeth Does that answer your question?

@langeth
Copy link
Author

langeth commented May 18, 2017

I have not time at the moment to look about this.

@batzen
Copy link
Member

batzen commented Jun 5, 2017

@langeth ping

@langeth
Copy link
Author

langeth commented Jun 6, 2017

Not really. I use
<DockPanel.LayoutTransform>

</DockPanel.LayoutTransform>
and then a Slider to Change the ScaleX and ScaleY.
Why it works with Fluent 4.03?

@batzen
Copy link
Member

batzen commented Jun 6, 2017

Did it really work in 4.03? Tranforms should only get applied to the element itself and its children, but not to parents.

@langeth
Copy link
Author

langeth commented Jun 6, 2017

Yes it works with Fluent.Ribbon 4.0.3.394 and
Themes/Office2010/Blue.xaml

@batzen
Copy link
Member

batzen commented Jun 6, 2017

Will have a look at it again.

@batzen
Copy link
Member

batzen commented Jun 14, 2017

ok, it worked because parts of the titlebar were part of the ribbon.
In version 5 the titlebar was moved from the ribbon itself to the window.
Will have a look if i can fix that issue by forwarding the transforms.

@batzen
Copy link
Member

batzen commented Jun 14, 2017

Have a partially working solution. There should be a way to forward it reliably. Should be fixed in version 6 this week.

@batzen batzen closed this as completed in f69f8a7 Jun 15, 2017
@batzen
Copy link
Member

batzen commented Jun 15, 2017

LayoutTransform and RenderTransform can now be used directly on RibbonWindow as this now gets forwarded to the first template child of the window. Have a look at TestWindow at https://github.com/fluentribbon/Fluent.Ribbon/blob/develop/Fluent.Ribbon.Showcase/TestWindow.xaml#L18 in the showcase application for an example on how to use it.

@batzen batzen added this to the 6.0.0 milestone Jun 15, 2017
@langeth
Copy link
Author

langeth commented Jun 15, 2017

It works fine, thanks a lot batzen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants