Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BackstageTabItem Is Never Deselected if BackstageTabControl is not Logical Parent #419

Closed
dartt opened this issue Mar 31, 2017 · 0 comments
Assignees
Labels
Milestone

Comments

@dartt
Copy link

dartt commented Mar 31, 2017

It seems that if a BackstageTabItem is not defined directly in the XAML, it will not be deselected when another BackstageTabItem is selected and the SelectedContent of the BackstageTabControl will not be updated.

It looks like this is because the parent BackstageTabControl is found by calling container.Parent in BackstageTabItem.OnIsSelectedChanged, which will only get the logical parent.

If the BackstageTabItem was created by DataTemplate, it won't have a logical parent, and this will return null.

It may be that this just needs to change from container.Parent to this.TabControlParent (which seems to get the parent control from the visual tree rather than the logical tree).


Environment

  • Fluent.Ribbon v5.0.1
  • Windows 10
  • .NET Framework 4.5
@batzen batzen self-assigned this Apr 1, 2017
@batzen batzen added the Bug 🐞 label Apr 1, 2017
@batzen batzen added this to the 6.0.0 milestone Apr 1, 2017
@batzen batzen closed this as completed in db1bd77 Apr 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants