Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combobox items will be drawn above each other on scroll down #305

Closed
Hypnos3 opened this issue Apr 18, 2016 · 8 comments
Closed

Combobox items will be drawn above each other on scroll down #305

Hypnos3 opened this issue Apr 18, 2016 · 8 comments
Assignees
Labels
Milestone

Comments

@Hypnos3
Copy link

Hypnos3 commented Apr 18, 2016

Environment

  • Fluent.Ribbon v4.0.3.394
  • Theme Office2013
  • Windows 7
  • .NET Framework 4.0

Combobox shows items wrong.

on Scrolling a large list, the items would be drawn above each other:
image

image

When scrolbar is at the top, all is fine:
image

This problem occures in the version from GitHb from Today (2016-04-18) or from actual version on NuGet.

@batzen
Copy link
Member

batzen commented Apr 19, 2016

Will have a look.

@batzen
Copy link
Member

batzen commented Apr 19, 2016

I can't reproduce your exact problem. On my machine the scrolling is totally broken.
I guess the problems are related to each other.
Could you try to reproduce your issue with the latest sources from the develop branch?

@batzen batzen added this to the 5.0.0 milestone Apr 19, 2016
@batzen batzen self-assigned this Apr 19, 2016
@Hypnos3
Copy link
Author

Hypnos3 commented Apr 19, 2016

Thank you for your testing.

I will try to reproduce this tomorrow.
Am 19.04.2016 18:51 schrieb "Bastian Schmidt" [email protected]:

I can't reproduce your exact problem. On my machine the scrolling is
totally broken.
I guess the problems are related to each other.
Could you try to reproduce your issue with the latest sources from the
develop branch?


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#305 (comment)

@Hypnos3
Copy link
Author

Hypnos3 commented Apr 20, 2016

With the code from latest develop branch the problem is solved.

An unattractiveness is now, if an element is selected and the combobox is opened, the scrollbar is always at the end. As far as I can remember the normal combobox behaviour is that the selected element is in the view.

@batzen
Copy link
Member

batzen commented Apr 20, 2016

Ok, my fix fixes the weird drawing but also destroys virtualization.

Will have to find different solution.

@batzen batzen changed the title Combobox items will be drawn above each other on scrol down Combobox items will be drawn above each other on scroll down Apr 23, 2016
@batzen
Copy link
Member

batzen commented Apr 23, 2016

I pushed the changes for #309, please check how it works for you.

@Hypnos3
Copy link
Author

Hypnos3 commented Apr 27, 2016

Yes, this is working if I use your suggestion:

On the ComboBox:

ScrollViewer.CanContentScroll="False"

itemspanel:

<Fluent:ComboBox.ItemsPanel>
    <ItemsPanelTemplate>
        <Fluent:GalleryPanel GroupBy="Tag"
                                ItemContainerGenerator="{Binding ItemContainerGenerator, RelativeSource={RelativeSource FindAncestor, AncestorType=ComboBox}}" />
    </ItemsPanelTemplate>
</Fluent:ComboBox.ItemsPanel>

@Hypnos3 Hypnos3 closed this as completed Apr 27, 2016
@batzen
Copy link
Member

batzen commented Apr 27, 2016

Glad to hear that it works for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants