Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line break in _minimizeButtonScreenTipText #30

Closed
pekspro opened this issue Nov 30, 2014 · 5 comments
Closed

Line break in _minimizeButtonScreenTipText #30

pekspro opened this issue Nov 30, 2014 · 5 comments
Assignees
Labels
Milestone

Comments

@pekspro
Copy link
Contributor

pekspro commented Nov 30, 2014

In RibbonLocation.cs there is this line:

_minimizeButtonScreenTipText = "Need a bit more space? Collapse the\nribbon so only the tab names show.";

The line break before "ribbon" looks quite funny in the tooltip I think.

@batzen batzen added the Bug 🐞 label Dec 1, 2014
@batzen batzen self-assigned this Dec 1, 2014
@batzen batzen added this to the 3.2.0 milestone Dec 1, 2014
@batzen
Copy link
Member

batzen commented Dec 1, 2014

German translation was wrong too ;-)

@batzen batzen closed this as completed in f285cc6 Dec 1, 2014
@pekspro
Copy link
Contributor Author

pekspro commented Dec 2, 2014

It looks like it’s in even more languages :-). In Swedish it should be:

_minimizeButtonScreenTipTitle = "Minimera menyfliksområdet (Ctrl + F1)";
_minimizeButtonScreenTipText = "Visa eller göm menyfliksområdet \n\nNär menyfliksområdet är dolt, visas endast flikarna";
_expandButtonScreenTipTitle = "Expandera menyfliksområdet (Ctrl + F1)";
_expandButtonScreenTipText = "Visa eller göm menyfliksområdet \n\nNär menyfliksområdet är dolt, visas endast flikarna";

(_minimizeButtonScreenTipText and _expandButtonScreenTipText is changed). In Danish _expandButtonScreenTipText should be:

_expandButtonScreenTipText = "Vis båndet, så det altid er udvidet, selv når du klikker på en kommando.";

But I suspect that also Russion, Ukrainian, French etc should be changed. I haven’t tried these languages but I think there are some suspicious \n in code.

@batzen
Copy link
Member

batzen commented Dec 3, 2014

Could you fix it and create a PR? I don't trust the possible encoding conversions here on github.
Just fix the translations which are wrong and remove the line breaks everywhere.

@pekspro
Copy link
Contributor Author

pekspro commented Dec 4, 2014

Ah....! I already had a fork so I tried to create a new one (following https://adrianshort.org/create-multiple-forks-of-a-github-repo/). But GitHub doesn't understand that this is fork from your project :-( Any suggestion how to solve this?

Eitherway, it's just one file and you find it here. I checked and tested all languages (very boring.... :-)
https://github.com/pekspro/Fluent.Ribbon.Issue30/tree/master/Fluent

@pekspro
Copy link
Contributor Author

pekspro commented Dec 7, 2014

Please ignore my previous message. I will rearrange my project so I make my private adaptions in the different branch. Then I should be able to create a pull request based on your project.

pekspro added a commit to pekspro/Fluent.Ribbon that referenced this issue Dec 7, 2014
batzen added a commit that referenced this issue Dec 8, 2014
Fix issue #30 - Line break in _minimizeButtonScreenTipText
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants