Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icons of buttons not aligned correctly in Office 2013 theme #253

Closed
floele-ww opened this issue Jan 25, 2016 · 5 comments
Closed

Icons of buttons not aligned correctly in Office 2013 theme #253

floele-ww opened this issue Jan 25, 2016 · 5 comments
Labels
Styles
Milestone
4.0.0

Comments

@floele-ww
Copy link
Contributor

See attached screenshot. The icon of the SplitButton is 1 px more to the right than the icons of other buttons (Button, DropDownButton). This probably is because of the added border. I'm not quite sure whether the SplitButton or the other buttons need to be fixed though. I believe the SplitButton should keep the 1px distance to it's border and all other buttons should use 2 px distance?

buttons

When comparing to Office 2013, it indeed looks like the margin can be increased because it's more than 1 px (in fact 3 px) here:

25-01-2016 08-20-21
@batzen batzen added the Styles label Jan 25, 2016
@batzen
Copy link
Member

batzen commented Jan 29, 2016

I agree that it's off but honestly I am kind of fed up with fixing pixel issues...
Especially in SplitButton it's very difficult to get it right in every condition.

I might fix this, but it's very (very, very, very) low on my priority list.

@floele-ww
Copy link
Contributor Author

If I look into that myself, which further conditions should I keep in mind?

@batzen
Copy link
Member

batzen commented Jan 31, 2016

  • Zooming (because that changes TextFormattingMode)
  • Different sizes of the control(s) (Small, Middle, Large)
  • .NET 4.0 (but that's not really important as i was thinking of dropping support for it in the near future)

@batzen
Copy link
Member

batzen commented Mar 19, 2016

Any news on this one?

@floele-ww
Copy link
Contributor Author

Didn't get time to look into this yet. It's still on my mind though.

@batzen batzen mentioned this issue Apr 3, 2016
Merged
@batzen batzen added this to the 4.0.0 milestone Apr 5, 2016
@batzen batzen closed this as completed Apr 5, 2016
batzen added a commit that referenced this issue Apr 6, 2016
@batzen
Merge pull request #290 from floele-sp/develop
b0e3ab7 
Fixed incorrect icon alignment in Office 2013 theme (issue #253)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Styles
Projects
None yet
Milestone
4.0.0
Development

No branches or pull requests
2 participants
@batzen @floele-ww