Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENHANCEMENT: add the additional checksum as a supported put parameter #430

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

joe-pll
Copy link

@joe-pll joe-pll commented Sep 5, 2023

Hi, I'm proposing this Pull Request because S3 supports additional checksum options for creating the hash at the upload.
I tested it on my side and it works. What do you think?

Thanks a lot in advance.

@ashie
Copy link
Member

ashie commented Oct 2, 2023

Thanks for you contribution!
Could you resolve a failed check?: https://github.com/fluent/fluent-plugin-s3/pull/430/checks?check_run_id=16515271824

@joe-pll joe-pll force-pushed the include-additional-checksums branch from a38c84d to 348a1f0 Compare October 5, 2023 14:52
@joe-pll
Copy link
Author

joe-pll commented Oct 5, 2023

Hi @ashie I modified the commit as requested. Can you please re-run the pipeline?

Copy link

github-actions bot commented Nov 5, 2023

This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 7 days

@github-actions github-actions bot added the stale label Nov 5, 2023
@joe-pll
Copy link
Author

joe-pll commented Nov 6, 2023

Hi @ashie, do you have any update on this?

@daipom
Copy link
Contributor

daipom commented Dec 7, 2023

Sorry for the late response.
I will see this.

@daipom daipom self-requested a review December 7, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants