add option to configure hostNetwork daemonset propertie #863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You'll need to sign your commit: |
Signed-off-by: Ivan Kolesnikov <[email protected]>
ikolesnikovrevizto
force-pushed
the
master
branch
from
977b5c4
to
4553d44
Compare
done |
benjaminhuo
reviewed
Aug 4, 2023
| @@ -97,6 +97,8 @@ fluentbit: | |||
| imagePullSecrets: [] | |||
| # - name: "image-pull-secret" | |||
| secrets: [] | |||
| # fluent-bit daemonset use host network | |||
| hostNetwork: false | |||
There was a problem hiding this comment.
@wanjunlei what's the previous default value for hostNetwork?
We should keep the default as before to avoid breaking anything
There was a problem hiding this comment.
The default value is false.
benjaminhuo
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
add option to setup hostNetwork for daemonset
Which issue(s) this PR fixes:
#862
Fixes #
Does this PR introduced a user-facing change?
None
Additional documentation, usage docs, etc.: