Adding forward input plugin configuration #843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yash97
changed the title
wenchajun
reviewed
Jul 24, 2023
| // Params implement Section() method | ||
| func (f *Forward) Params(_ plugins.SecretLoader) (*params.KVs, error) { | ||
| kvs := params.NewKVs() | ||
| if f.Port >= 0 && f.Port < 65535 { |
There was a problem hiding this comment.
https://github.com/fluent/fluent-operator/blob/master/apis/fluentbit/v1alpha2/plugins/output/elasticsearch_types.go#L18
You can refer to this modification
Signed-off-by: yash97 <[email protected]>
Signed-off-by: yash97 <[email protected]>
benjaminhuo
approved these changes
Jul 31, 2023
|
Just in time what I wanted, thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adding support for forward input plugin to operator.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduced a user-facing change?
Yes user can now turn on forward input plugin for fluentbit.
Additional documentation, usage docs, etc.:
I have added threaded option in fluentbit config. It's not mentioned in documentation as parameter for input plugin but it is generic parameter available for some plugins.