Remove influxdb host validation in ClusterOutput #1363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anson Liu <[email protected]>
wenchajun
approved these changes
Sep 29, 2024
|
Thanks for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR removes the validation of the ipv4, ipv6 and hostname. This is because the Kubebuilder doesn't support using multiple format validations for a single field. In original code, there were three formation validations(hostname, ipv4, ipv6), but only the last one(ipv6) would be applied.
This PR also remedies port range. The highest valid port number is 65535, not 65536. Port 0 is a reserved port in TCP/IP
Which issue(s) this PR fixes:
Fixes #1359
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.: