Fix fluentd path issues. #1195
Merged
Fix fluentd path issues. #1195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminhuo
approved these changes
Jun 5, 2024
|
That's great, thank you @sarathchandra24 ! |
BacLuc
added a commit
to BacLuc/ecamp3
that referenced
this pull request
Jun 9, 2024
This is the image: https://github.com/fluent/fluent-operator/blob/2de2b934e4d9f4475e278da7d9db74d89ef9a037/cmd/fluent-watcher/fluentd/Dockerfile.amd64 built in a devcontainer of the repository and then pushed to dockerhub. The command to build the container was: @BacLuc ➜ /workspaces/fluent-operator (master) $ docker build . -f cmd/fluent-watcher/fluentd/Dockerfile.amd64 -t docker.io/bacluc/fluentd:1.15.3 They seem to have problem with the images they publish in the fluent-operator repository. It also contains the following fix: fluent/fluent-operator#1195
This was referenced Jun 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
There has been an issue with fluentd coming up in docker images. Previous changes were handling only arch, as usr/local/bundle/bin/fluentd. But,
For amd64 it is"/usr/bin/fluentd"
For arm64 it is "/usr/local/bundle/bin/fluentd".
Which issue(s) this PR fixes:
Fixes #1187
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.: