Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrl+C / SIGINT should quit process cleanly #141

Open
mjp0 opened this issue Nov 23, 2017 · 1 comment
Open

Ctrl+C / SIGINT should quit process cleanly #141

mjp0 opened this issue Nov 23, 2017 · 1 comment

Comments

@mjp0
Copy link

mjp0 commented Nov 23, 2017

I have been getting familiar with fbp-spec and I have noticed that for some reason the process doesn't exit properly. It just hangs and my only option is to killall node.

It looks like something is hijacking SIGINT in fbp-spec (at least on macOS 10.12) because I can't CTRL+C out of the process either.

Same problem happens with noflo-nodejs.

edit This could be related to error handling as outlined in #137 because I noticed that my test had a broken fixture syntax thanks to auto-indent so now it works and exits properly.

@jonnor jonnor changed the title Something hijacking SIGINT Ctrl+C / SIGINT should quit process cleanly Dec 27, 2017
@jonnor
Copy link
Contributor

jonnor commented Dec 27, 2017

Probably need to add an explicit signal handler, and to call cleanup of runtime subprocess

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants