Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditions should support more than JUEL expressions #3884

Closed
rasmusfaber opened this issue May 7, 2024 · 0 comments · Fixed by #3889
Closed

Conditions should support more than JUEL expressions #3884

rasmusfaber opened this issue May 7, 2024 · 0 comments · Fixed by #3889

Comments

@rasmusfaber
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Conditions (and other places with FormalExpressions) currenly ignores the language attribute and always assumes that the content is JUEL. Some conditions are hard or impossible to write in JUEL (i.e. "is the country of one of the addresses in the US?"), so it would be great to be able to use i.e. Groovy instead.

Describe the solution you'd like

SequenceFlows (and BoundaryEvents etc.) should parse the language attribute of the bpmn:condition. ExpressionManager.createExpression() should use the language to load the ScriptEngine using javax.script.ScriptEngineManager, probably only accepting languages from a configurable whitelist.

It looks like a fairly straightforward task, and I will be happy to supply a PR, if I can get an indication that it is likely to be merged.

rasmusfaber added a commit to rasmusfaber/flowable-engine that referenced this issue May 14, 2024
rasmusfaber added a commit to rasmusfaber/flowable-engine that referenced this issue Aug 28, 2024
rasmusfaber added a commit to rasmusfaber/flowable-engine that referenced this issue Aug 28, 2024
rasmusfaber added a commit to rasmusfaber/flowable-engine that referenced this issue Aug 28, 2024
rasmusfaber added a commit to rasmusfaber/flowable-engine that referenced this issue Aug 28, 2024
tijsrademakers pushed a commit that referenced this issue Oct 3, 2024
…onditional events (#3889)

* #3884 Expression language support for conditional sequence flow and conditional events

* #3884: Use ScriptCondition instead of ScriptEngineExpression

* #3884: Move logic to ConditionUtil and leave ScriptCondition unchanged

* #3884: Rename sequenceFlowId to elementId. Revert whitespace-only changes.

* #3884: Pass the id of the event definition instead of the activity
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant