From 2b94a80edb577deaca841efc0a6d3eecfc290234 Mon Sep 17 00:00:00 2001 From: David B Malkovsky Date: Tue, 29 Aug 2023 07:48:37 -0400 Subject: [PATCH] Chore: remove duplicated semicolon (#3716) * Chore: remove duplicated semicolon * Chore: remove duplicated semicolon * Chore: remove unnecessary semicolon --- .../api/runtime/CaseInstanceCollectionResourceTest.java | 6 +++--- .../AbstractVariableComparatorExpressionFunction.java | 2 +- .../IntermediateThrowSignalEventActivityBehavior.java | 2 +- .../spring/test/jms/JmsChannelDefinitionProcessorTest.java | 2 +- .../task/service/impl/HistoricTaskInstanceQueryImpl.java | 1 - .../java/org/flowable/task/service/impl/TaskQueryImpl.java | 1 - 6 files changed, 6 insertions(+), 8 deletions(-) diff --git a/modules/flowable-cmmn-rest/src/test/java/org/flowable/cmmn/rest/service/api/runtime/CaseInstanceCollectionResourceTest.java b/modules/flowable-cmmn-rest/src/test/java/org/flowable/cmmn/rest/service/api/runtime/CaseInstanceCollectionResourceTest.java index 5b13776ba97..dd208b0a9a5 100644 --- a/modules/flowable-cmmn-rest/src/test/java/org/flowable/cmmn/rest/service/api/runtime/CaseInstanceCollectionResourceTest.java +++ b/modules/flowable-cmmn-rest/src/test/java/org/flowable/cmmn/rest/service/api/runtime/CaseInstanceCollectionResourceTest.java @@ -147,14 +147,14 @@ public void testGetCaseInstances() throws Exception { url = CmmnRestUrls.createRelativeResourceUrl(CmmnRestUrls.URL_CASE_INSTANCE_COLLECTION) + "?startedBefore=" + getISODateString(futureCal.getTime()); assertResultsPresentInDataResponse(url, id); - url = CmmnRestUrls.createRelativeResourceUrl(CmmnRestUrls.URL_CASE_INSTANCE_COLLECTION) + "?startedBefore=" + getISODateString(historicCal.getTime());; + url = CmmnRestUrls.createRelativeResourceUrl(CmmnRestUrls.URL_CASE_INSTANCE_COLLECTION) + "?startedBefore=" + getISODateString(historicCal.getTime()); assertResultsPresentInDataResponse(url); // Case instance started after - url = CmmnRestUrls.createRelativeResourceUrl(CmmnRestUrls.URL_CASE_INSTANCE_COLLECTION) + "?startedAfter=" + getISODateString(historicCal.getTime());; + url = CmmnRestUrls.createRelativeResourceUrl(CmmnRestUrls.URL_CASE_INSTANCE_COLLECTION) + "?startedAfter=" + getISODateString(historicCal.getTime()); assertResultsPresentInDataResponse(url, id); - url = CmmnRestUrls.createRelativeResourceUrl(CmmnRestUrls.URL_CASE_INSTANCE_COLLECTION) + "?startedAfter=" + getISODateString(futureCal.getTime());; + url = CmmnRestUrls.createRelativeResourceUrl(CmmnRestUrls.URL_CASE_INSTANCE_COLLECTION) + "?startedAfter=" + getISODateString(futureCal.getTime()); assertResultsPresentInDataResponse(url); // Case instance state diff --git a/modules/flowable-engine-common/src/main/java/org/flowable/common/engine/impl/el/function/AbstractVariableComparatorExpressionFunction.java b/modules/flowable-engine-common/src/main/java/org/flowable/common/engine/impl/el/function/AbstractVariableComparatorExpressionFunction.java index b7319c768a4..b748a561749 100644 --- a/modules/flowable-engine-common/src/main/java/org/flowable/common/engine/impl/el/function/AbstractVariableComparatorExpressionFunction.java +++ b/modules/flowable-engine-common/src/main/java/org/flowable/common/engine/impl/el/function/AbstractVariableComparatorExpressionFunction.java @@ -21,7 +21,7 @@ */ public abstract class AbstractVariableComparatorExpressionFunction extends AbstractFlowableVariableExpressionFunction { - protected enum OPERATOR { LT, LTE, GT, GTE, EQ }; + protected enum OPERATOR { LT, LTE, GT, GTE, EQ } public AbstractVariableComparatorExpressionFunction(List functionNameOptions, String functionName) { super(functionNameOptions, functionName); diff --git a/modules/flowable-engine/src/main/java/org/flowable/engine/impl/bpmn/behavior/IntermediateThrowSignalEventActivityBehavior.java b/modules/flowable-engine/src/main/java/org/flowable/engine/impl/bpmn/behavior/IntermediateThrowSignalEventActivityBehavior.java index 5efecfb642e..455a4b7e0f2 100644 --- a/modules/flowable-engine/src/main/java/org/flowable/engine/impl/bpmn/behavior/IntermediateThrowSignalEventActivityBehavior.java +++ b/modules/flowable-engine/src/main/java/org/flowable/engine/impl/bpmn/behavior/IntermediateThrowSignalEventActivityBehavior.java @@ -103,7 +103,7 @@ public void execute(DelegateExecution execution) { } Map payload = IOParameterUtil.extractOutVariables(throwEvent.getOutParameters(), execution, - processEngineConfiguration.getExpressionManager());; + processEngineConfiguration.getExpressionManager()); for (SignalEventSubscriptionEntity signalEventSubscriptionEntity : subscriptionEntities) { processEngineConfiguration.getEventDispatcher().dispatchEvent(FlowableEventBuilder.createSignalEvent(FlowableEngineEventType.ACTIVITY_SIGNALED, signalEventSubscriptionEntity.getActivityId(), eventSubscriptionName, diff --git a/modules/flowable-event-registry-spring/src/test/java/org/flowable/eventregistry/spring/test/jms/JmsChannelDefinitionProcessorTest.java b/modules/flowable-event-registry-spring/src/test/java/org/flowable/eventregistry/spring/test/jms/JmsChannelDefinitionProcessorTest.java index 68d698cee4e..edf7074fff0 100644 --- a/modules/flowable-event-registry-spring/src/test/java/org/flowable/eventregistry/spring/test/jms/JmsChannelDefinitionProcessorTest.java +++ b/modules/flowable-event-registry-spring/src/test/java/org/flowable/eventregistry/spring/test/jms/JmsChannelDefinitionProcessorTest.java @@ -712,7 +712,7 @@ void jmsOutboundChannelShouldResolveDestinationFromExpressionUsingCombinationFor Object message = await("receive message") .atMost(Duration.ofSeconds(10)) - .until(() -> jmsTemplate.receiveAndConvert("test-combination.test-expression-customer"), Objects::nonNull);; + .until(() -> jmsTemplate.receiveAndConvert("test-combination.test-expression-customer"), Objects::nonNull); assertThat(message).isNotNull(); assertThatJson(message) .isEqualTo("{" diff --git a/modules/flowable-task-service/src/main/java/org/flowable/task/service/impl/HistoricTaskInstanceQueryImpl.java b/modules/flowable-task-service/src/main/java/org/flowable/task/service/impl/HistoricTaskInstanceQueryImpl.java index ab1ff7ffe1b..a9279538053 100644 --- a/modules/flowable-task-service/src/main/java/org/flowable/task/service/impl/HistoricTaskInstanceQueryImpl.java +++ b/modules/flowable-task-service/src/main/java/org/flowable/task/service/impl/HistoricTaskInstanceQueryImpl.java @@ -1279,7 +1279,6 @@ public HistoricTaskInstanceQuery caseVariableValueNotEquals(String variableName, currentOrQueryObject.scopedVariableValueNotEquals(variableName, variableValue, ScopeTypes.CMMN); } else { this.scopedVariableValueNotEquals(variableName, variableValue, ScopeTypes.CMMN); - ; } return this; } diff --git a/modules/flowable-task-service/src/main/java/org/flowable/task/service/impl/TaskQueryImpl.java b/modules/flowable-task-service/src/main/java/org/flowable/task/service/impl/TaskQueryImpl.java index c35e8e5fca9..29f79e0e9cc 100644 --- a/modules/flowable-task-service/src/main/java/org/flowable/task/service/impl/TaskQueryImpl.java +++ b/modules/flowable-task-service/src/main/java/org/flowable/task/service/impl/TaskQueryImpl.java @@ -1374,7 +1374,6 @@ public TaskQuery caseVariableValueNotEquals(String variableName, Object variable currentOrQueryObject.scopedVariableValueNotEquals(variableName, variableValue, ScopeTypes.CMMN); } else { this.scopedVariableValueNotEquals(variableName, variableValue, ScopeTypes.CMMN); - ; } return this; }