Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add it to a package archive!? #1

Open
curable-online opened this issue Jun 16, 2024 · 5 comments
Open

[Feature Request] Add it to a package archive!? #1

curable-online opened this issue Jun 16, 2024 · 5 comments

Comments

@curable-online
Copy link

Hello, thanks for this perfect theme. I Would love to see more people know that such a theme does, indeed, exit! Would you love too?

Most Emacs users do not search GitHub for an Emacs package, but Emacs' package archives. — Well, many Emacs packages aren't available as a github repo at all.

Opinion?

@florommel
Copy link
Owner

Thank you very much. Nice to hear that there are other users besides me ;)

Hm, we could try to get this theme into ELPA.
I'll have to do a bit of cleanup work first... at least complete the documentation.

@curable-online
Copy link
Author

Can I do any help?

@curable-online
Copy link
Author

Like generally overviewing current documentation?

Or You have something specific in your mind?

@florommel
Copy link
Owner

Thank you for your offer to help! I don't have a lot of time at the moment, so I don't have a detailed overview of what still needs to be done.

What worries me a bit is the complicated macro construction. Ideally, it could be simplified a bit and at least the TODOs and FIXMEs could be fixed. However, I don't want to expect anyone to work their way into it... at least not before I have documented it a bit.

Apart from the documentation: Emacs now offers the option to declare theme variants (theme-choose-variant). Maybe we should declare "day", "night", and "midnight" as variants instead of as separate themes.

@curable-online
Copy link
Author

Unfortunately, I just have started learning elisp and I don't have
enough knowledge to do technical helps, yet.

Apart from the documentation: Emacs now offers the option to declare theme variants (theme-choose-variant). Maybe we should declare "day", "night", and "midnight" as variants instead of as separate themes.

I think that would be great from a user’s perspective.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants