Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PS3: misprint and one suggestion #56

Open
DSKoch opened this issue Oct 21, 2021 · 9 comments
Open

PS3: misprint and one suggestion #56

DSKoch opened this issue Oct 21, 2021 · 9 comments
Labels

Comments

@DSKoch
Copy link

DSKoch commented Oct 21, 2021

  1. It is written that Odd pipeline has “a puny Fixed-Point Unit” but the figure is drawn a Floating-Point Unit.
  2. I have a suggestion to change arrows between Ramps to the “Simplified diagram of the Element Interconnect Bus (EIB)” to arrows with two lines. So the total number of lines will be the same as the number of Rings.
    Example: https://images.app.goo.gl/MbaWxQYTocf6AFzT7

Thank you for your articles!

@flipacholas
Copy link
Owner

  1. You're right (the text is right, the diagram is not).
  2. Good idea, I'll check if draw.io has something like that.

You're welcome and thanks!

@flipacholas
Copy link
Owner

Fixed-point unit diagram fixed

@DSKoch
Copy link
Author

DSKoch commented Oct 22, 2021

I have one more suggestion.
From the beginning in every figure one of SPU is painted in another colour and the reader asks himself why. Answer for this question is given far away from these figures. I suggest mentioning OS reservation in the same place where you wrote about why one SPU is disabled.

@flipacholas
Copy link
Owner

The problem is that the reader may not know what the SPU is or how the OS is composed, yet. So I have the impression adding that info so early would make it more difficult to follow the article.

@DSKoch
Copy link
Author

DSKoch commented Oct 24, 2021

I don’t think it overcomplicate the article. Moreover, in “3.6.1.2 The Synergistic Processor Unit” you wrote “remember there are seven to choose from”. As we know game developers have only six to choose from. In my opinion it’s better to clarify this point earlier. At this moment the reader only needs to know that of the eight SPU one is disabled, one is performing OS tasks and six are available for games.

@flipacholas
Copy link
Owner

I'll still try to find a way to bring the double arrows to the diagrams.

@DSKoch
Copy link
Author

DSKoch commented Dec 1, 2021

If I understand correctly, for diagrams you use draw.io. The double arrows are in “General”.

@DSKoch DSKoch reopened this Dec 1, 2021
@flipacholas
Copy link
Owner

Screenshot 2021-12-01 at 18 46 57

None seem as good as:

image

@DSKoch
Copy link
Author

DSKoch commented Dec 1, 2021

“Handmade” arrow that looks very similar.

Consist from two lines. Styles for them.

endArrow=none;html=1;rounded=1;strokeColor=#000000;strokeWidth=1;jumpStyle=none;jumpSize=6;shape=link;width=4;

endArrow=none;html=1;rounded=0;strokeColor=#000000;strokeWidth=1;jumpStyle=none;jumpSize=6;elbow=vertical;

Untitled Diagram - diagrams net

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants