Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add --local-template-path / --localTemplatePath option to rnv new #1664

Merged
merged 4 commits into from
Aug 30, 2024

Conversation

ElenaDiachenko
Copy link
Contributor

Description

  • Being able to pass a local template to rnv new non-interactively using cli option

    Example:
    rnv new --local-template-path /Users/olenadiachenko/GitHub/renative/packages/template-starter

Related issues

Npm releases

n/a

@ElenaDiachenko ElenaDiachenko self-assigned this Aug 27, 2024
@ElenaDiachenko ElenaDiachenko added this to the 1.2 milestone Aug 27, 2024
@pauliusguzas pauliusguzas added bug Something isn't working e2e and removed bug Something isn't working e2e labels Aug 27, 2024
@pauliusguzas pauliusguzas self-requested a review August 28, 2024 07:53
Copy link
Collaborator

@pauliusguzas pauliusguzas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getting this question when passing path using flag

? Would you like to add @rnv/template-starter to your rnv workspace template lis
t? (Y/n)

when using cli this question doesn't pop up and my renative.json already has this added, so it shouldn't appear

@pauliusguzas pauliusguzas added e2e and removed e2e labels Aug 28, 2024
@pauliusguzas pauliusguzas self-requested a review August 29, 2024 07:20
@pauliusguzas pauliusguzas added e2e and removed e2e labels Aug 29, 2024
@ElenaDiachenko ElenaDiachenko merged commit d703994 into release/1.0 Aug 30, 2024
10 of 11 checks passed
@ElenaDiachenko ElenaDiachenko deleted the localTemplatePath_option_added branch August 30, 2024 08:57
locksten pushed a commit that referenced this pull request Aug 30, 2024
add --local-template-path / --localTemplatePath option to rnv new

(cherry picked from commit d703994)
@ElenaDiachenko ElenaDiachenko restored the localTemplatePath_option_added branch September 2, 2024 06:35
ElenaDiachenko added a commit that referenced this pull request Sep 2, 2024
…te-path-fix

Merge pull request #1664 from flexn-io/localTemplatePath_option_added
@ElenaDiachenko ElenaDiachenko deleted the localTemplatePath_option_added branch September 2, 2024 07:23
@ElenaDiachenko ElenaDiachenko mentioned this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants