Return promises in onsubmit #2589
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows extensions using the `extend` util to react to the server's response with `then`s.
KyrneDev
reviewed
Feb 3, 2021
| @@ -161,7 +161,7 @@ export default class SignUpModal extends Modal { | |||
|
|
|||
| const body = this.submitData(); | |||
|
|
|||
| app | |||
| return app | |||
There was a problem hiding this comment.
Wouldn’t this be pointless/need more changes since the window is reloaded? Any then statement after wouldn’t be able to run.
|
This really isn’t the solution I would hope for. The reason extensions override the sign up and login modal are because it reloads at the end. It’s great that the mail page can now do this, but it isn’t all that useful compared to these 2. |
|
I think I'm going to close this for now, it's not particularly universal as a solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows extensions using the
extendutil to react to the server's response withthens. There might be other places we want to do this.One example of a use case is FriendsOfFlarum/drafts#18