Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Images #606

Draft
wants to merge 23 commits into
base: master
Choose a base branch
from
Draft

Add Images #606

wants to merge 23 commits into from

Conversation

addie9800
Copy link
Collaborator

No description provided.

@addie9800 addie9800 marked this pull request as draft September 4, 2024 09:58
@MaxDall
Copy link
Collaborator

MaxDall commented Sep 13, 2024

@addie9800 Thanks for pushing this idea 👍 I think this would be an awesome addition to Fundus! 🚀

It looks like you accidentally pushed a lot of unrelated files to the draft, making it harder for me to focus on the core idea. Would you mind removing those files so we can talk about the changes?

@addie9800
Copy link
Collaborator Author

Ah well, sorry about that. I did only intend to push one extra file :)... I cleaned up a bit now, in case you want to have a look at it, but I haven't reached a real milestone yet, since you last had a peek at it. I think the issue I am struggling with most at the moment is the dynamic rescaling of images where some publishers change the path of the url according to the necessary resolution for the given screen, making it difficult to come up with a selector for the corresponding img element. If you have any idea, shoot ;)

@addie9800
Copy link
Collaborator Author

@addie9800
Copy link
Collaborator Author

Update: As of now, I have verified the functionality for TheNamibian, DerStandard, ORF, NineNews and CBCNews. They can be used to get an impression of the intended functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants